[breaking] Update submodules #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/mq とは言えmainブランチを追い続けるのがこのプロジェクトなので、mergeする |
|
Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/9254883152
If you want to cancel the test, you can cancel it by GitHub CLI below command:
|
yamachu
commented
May 27, 2024
| @@ -50,7 +50,8 @@ jobs: | |||
| - run: | | |||
| cp open_jtalk_dic_utf_8-1.11.tar.gz ./tests/VoicevoxCoreSharp.Core.Tests/resources | |||
| tar zxf ./tests/VoicevoxCoreSharp.Core.Tests/resources/open_jtalk_dic_utf_8-1.11.tar.gz -C tests/VoicevoxCoreSharp.Core.Tests/resources/ | |||
| - run: cp -r binding/voicevox_core/model ./tests/VoicevoxCoreSharp.Core.Tests/resources | |||
| - name: sample.vvmを自前でzipコマンドで作成する | |||
| run: mkdir -p tests/VoicevoxCoreSharp.Core.Tests/resources/model; cd binding/voicevox_core/model/sample.vvm; zip -r ../../../../tests/VoicevoxCoreSharp.Core.Tests/resources/model/sample.vvm . | |||
There was a problem hiding this comment.
本来は crates/test_util/data/model 以下に生成された sample.vvm を使用するのがいいが、cacheなどの関係上変更が若干面倒なので、やるとしても別のPRで出来るようにしたい
|
/mq |
8 similar comments
|
/mq |
|
Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/9269959809
If you want to cancel the test, you can cancel it by GitHub CLI below command:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
コード上の変更
breaking