Skip to content

Commit 1db1671

Browse files
committed
Don't enable ErrorProne in tests, if errorprone in main. Disable ErrorProne in tests, if ErrorProne in main only
Don't enable ErrorProne in tests, if errorprone in main. Disable ErrorProne in tests, if ErrorProne in main only commit_hash:ce94862ec87a3a24b6dfb5d6bc794a6b019bbb57
1 parent 3fd18c0 commit 1db1671

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

build/export_generators/ide-gradle/javac_flags.jinja

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{%- macro JavacFlags(task, target_javac_flags, has_errorprone) -%}
1+
{%- macro JavacFlags(task, target_javac_flags, has_errorprone, dis_errorprone) -%}
22
{%- set target_javac_flags = target_javac_flags|unique -%}
33
{%- set javac_flags = [] -%}
44
{%- set compiler_jvm_flags = [] -%}
@@ -71,11 +71,13 @@ tasks.{{ task }}.configure {
7171
{%- endif -%}
7272
{%- endfor -%}
7373
{%- endif -%}
74+
{%- elif dis_errorprone %}
75+
options.errorprone.isEnabled.set(false)
7476
{%- endif %}
7577
}
7678
{% endif -%}
7779
{% endmacro -%}
7880
{#- glue -#}
79-
{{ JavacFlags("compileJava", target.javac.flags, with_errorprone) }}
81+
{{ JavacFlags("compileJava", target.javac.flags, with_errorprone, false) }}
8082
{#- glue -#}
81-
{{ JavacFlags("compileTestJava", all_targets|selectattr('javac')|map(attribute='javac')|selectattr('flags')|map(attribute='flags')|sum, with_errorprone or with_test_errorprone) }}
83+
{{ JavacFlags("compileTestJava", all_targets|selectattr('javac')|map(attribute='javac')|selectattr('flags')|map(attribute='flags')|sum, with_test_errorprone, with_errorprone) }}

build/export_generators/ide-gradle/vars.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
{#- ErrorProne -#}
3030
{%- set with_errorprone = not(disable_errorprone) and (target.use_errorprone) and (target.consumer|selectattr('jar', 'startsWith', 'contrib/java/com/google/errorprone/error_prone_annotations')|length) -%}
31-
{%- set with_test_errorprone = not(disable_errorprone) and (extra_targets|selectattr('use_errorprone', 'eq', true)|length) and (extra_targets|selectattr('consumer')|map(attribute='consumer')|sum|selectattr('jar', 'startsWith', 'contrib/java/com/google/errorprone/error_prone_annotations')|length) -%}
31+
{%- set with_test_errorprone = not(disable_errorprone) and not(disable_test_errorprone) and (extra_targets|selectattr('use_errorprone', 'eq', true)|length) and (extra_targets|selectattr('consumer')|map(attribute='consumer')|sum|selectattr('jar', 'startsWith', 'contrib/java/com/google/errorprone/error_prone_annotations')|length) -%}
3232
{%- if with_errorprone or with_test_errorprone -%}
3333
{%- set errorprones = all_targets|selectattr('consumer')|map(attribute='consumer')|sum|selectattr('classpath')|selectattr('jar', 'startsWith', 'contrib/java/com/google/errorprone/error_prone_annotations')|unique -%}
3434
{%- endif -%}

0 commit comments

Comments
 (0)