From a21ee7fff8a303ee7c4ba5b2dc1f68ed83f317dd Mon Sep 17 00:00:00 2001
From: yanguoyu <841185308@qq.com>
Date: Fri, 12 Jan 2024 16:29:17 +0800
Subject: [PATCH] fix: Disable unlock when there is no ckb.

---
 .../src/components/NervosDAO/index.tsx        |  1 +
 .../NervosDAORecord/daoRecordRow.module.scss  |  5 +++
 .../src/components/NervosDAORecord/index.tsx  | 41 +++++++++++++++----
 packages/neuron-ui/src/locales/en.json        |  3 +-
 packages/neuron-ui/src/locales/fr.json        |  3 +-
 packages/neuron-ui/src/locales/zh-tw.json     |  3 +-
 packages/neuron-ui/src/locales/zh.json        |  3 +-
 .../src/controllers/app/index.ts              |  2 +
 8 files changed, 48 insertions(+), 13 deletions(-)

diff --git a/packages/neuron-ui/src/components/NervosDAO/index.tsx b/packages/neuron-ui/src/components/NervosDAO/index.tsx
index 0246117032..a551011577 100644
--- a/packages/neuron-ui/src/components/NervosDAO/index.tsx
+++ b/packages/neuron-ui/src/components/NervosDAO/index.tsx
@@ -179,6 +179,7 @@ const NervosDAO = () => {
                 genesisBlockTimestamp,
                 connectionStatus,
                 isPrivacyMode,
+                hasCkbBalance: !!wallet.balance && wallet.balance !== '0',
               }
               return <DAORecord key={key} {...props} />
             })}
diff --git a/packages/neuron-ui/src/components/NervosDAORecord/daoRecordRow.module.scss b/packages/neuron-ui/src/components/NervosDAORecord/daoRecordRow.module.scss
index a8ae72a98c..c533d52c3f 100644
--- a/packages/neuron-ui/src/components/NervosDAORecord/daoRecordRow.module.scss
+++ b/packages/neuron-ui/src/components/NervosDAORecord/daoRecordRow.module.scss
@@ -249,5 +249,10 @@
       line-height: 56px;
       padding: 0;
     }
+
+    .tip {
+      width: 220px;
+      white-space: normal;
+    }
   }
 }
diff --git a/packages/neuron-ui/src/components/NervosDAORecord/index.tsx b/packages/neuron-ui/src/components/NervosDAORecord/index.tsx
index 2dc5dca037..eab1433cac 100644
--- a/packages/neuron-ui/src/components/NervosDAORecord/index.tsx
+++ b/packages/neuron-ui/src/components/NervosDAORecord/index.tsx
@@ -19,6 +19,7 @@ import { Clock } from 'widgets/Icons/icon'
 import { Link } from 'react-router-dom'
 import { HIDE_BALANCE } from 'utils/const'
 
+import Tooltip from 'widgets/Tooltip'
 import styles from './daoRecordRow.module.scss'
 import hooks from './hooks'
 
@@ -42,6 +43,7 @@ export interface DAORecordProps extends State.NervosDAORecord {
   tipBlockTimestamp: number // tip block timestamp, used to calculate apc, dovetails with current epoch
   genesisBlockTimestamp: number | undefined // genesis block timestamp, used to calculate apc
   isPrivacyMode?: boolean
+  hasCkbBalance?: boolean
 }
 
 export const DAORecord = ({
@@ -62,6 +64,7 @@ export const DAORecord = ({
   withdrawInfo,
   unlockInfo,
   isPrivacyMode,
+  hasCkbBalance,
 }: DAORecordProps) => {
   const [t] = useTranslation()
   const [withdrawEpoch, setWithdrawEpoch] = useState('')
@@ -143,8 +146,11 @@ export const DAORecord = ({
   const compensatedPeriod =
     withdrawInfo?.timestamp && depositInfo?.timestamp ? +withdrawInfo.timestamp - +depositInfo.timestamp : undefined
 
+  const isWithdrawnDisabled = CellStatus.Deposited === cellStatus && !hasCkbBalance
   const isActionAvailable =
-    connectionStatus === 'online' && [CellStatus.Deposited, CellStatus.Unlockable].includes(cellStatus)
+    connectionStatus === 'online' &&
+    [CellStatus.Deposited, CellStatus.Unlockable].includes(cellStatus) &&
+    !isWithdrawnDisabled
 
   const depositOutPointKey = depositOutPoint
     ? `${depositOutPoint.txHash}-${depositOutPoint.index}`
@@ -277,14 +283,31 @@ export const DAORecord = ({
           </div>
 
           <div className={styles.action}>
-            <Button
-              type="primary"
-              data-tx-hash={txHash}
-              data-index={index}
-              onClick={onClick}
-              disabled={!isActionAvailable}
-              label={t(`nervos-dao.deposit-record.${isWithdrawn ? 'unlock' : 'withdraw'}-action-label`)}
-            />
+            {isWithdrawnDisabled ? (
+              <Tooltip
+                tip={<div>{t('nervos-dao.deposit-record.no-ckb')}</div>}
+                placement="top"
+                tipClassName={styles.tip}
+              >
+                <Button
+                  type="primary"
+                  data-tx-hash={txHash}
+                  data-index={index}
+                  onClick={onClick}
+                  disabled={!isActionAvailable}
+                  label={t(`nervos-dao.deposit-record.${isWithdrawn ? 'unlock' : 'withdraw'}-action-label`)}
+                />
+              </Tooltip>
+            ) : (
+              <Button
+                type="primary"
+                data-tx-hash={txHash}
+                data-index={index}
+                onClick={onClick}
+                disabled={!isActionAvailable}
+                label={t(`nervos-dao.deposit-record.${isWithdrawn ? 'unlock' : 'withdraw'}-action-label`)}
+              />
+            )}
           </div>
         </div>
       )}
diff --git a/packages/neuron-ui/src/locales/en.json b/packages/neuron-ui/src/locales/en.json
index e0d6782f8f..9fc6163321 100644
--- a/packages/neuron-ui/src/locales/en.json
+++ b/packages/neuron-ui/src/locales/en.json
@@ -689,7 +689,8 @@
         "compensated-period": "Compensation Period",
         "days-hours": "{{days}} days {{hours}} hours",
         "no-deposit": "No Deposit",
-        "no-completed": "No Completed"
+        "no-completed": "No Completed",
+        "no-ckb": "No other CKB to pay for transaction fee that unlock DAO"
       },
       "compensation-period": {
         "tooltip": {
diff --git a/packages/neuron-ui/src/locales/fr.json b/packages/neuron-ui/src/locales/fr.json
index e7445298cc..16f1e94756 100644
--- a/packages/neuron-ui/src/locales/fr.json
+++ b/packages/neuron-ui/src/locales/fr.json
@@ -689,7 +689,8 @@
         "compensated-period": "Période de compensation",
         "days-hours": "{{days}} jours {{hours}} heures",
         "no-deposit": "Aucun dépôt",
-        "no-completed": "Aucun terminé"
+        "no-completed": "Aucun terminé",
+        "no-ckb": "Pas de ckb supplémentaire pour payer les frais de traitement pour déverrouiller le DAO"
       },
       "compensation-period": {
         "tooltip": {
diff --git a/packages/neuron-ui/src/locales/zh-tw.json b/packages/neuron-ui/src/locales/zh-tw.json
index 44b240120b..85df260723 100644
--- a/packages/neuron-ui/src/locales/zh-tw.json
+++ b/packages/neuron-ui/src/locales/zh-tw.json
@@ -682,7 +682,8 @@
         "compensated-period": "補貼時間",
         "days-hours": "{{days}} 天 {{hours}} 小時",
         "no-deposit": "沒有存入記錄",
-        "no-completed": "沒有解鎖記錄"
+        "no-completed": "沒有解鎖記錄",
+        "no-ckb": "沒有額外的 CKB 用於支付解鎖 DAO 的手續費"
       },
       "compensation-period": {
         "tooltip": {
diff --git a/packages/neuron-ui/src/locales/zh.json b/packages/neuron-ui/src/locales/zh.json
index 6a5b89f526..afd18aa45b 100644
--- a/packages/neuron-ui/src/locales/zh.json
+++ b/packages/neuron-ui/src/locales/zh.json
@@ -682,7 +682,8 @@
         "compensated-period": "补贴时间",
         "days-hours": "{{days}} 天 {{hours}} 小时",
         "no-deposit": "没有存入记录",
-        "no-completed": "没有解锁记录"
+        "no-completed": "没有解锁记录",
+        "no-ckb": "没有额外的 CKB 用于支付解锁 DAO 的手续费"
       },
       "compensation-period": {
         "tooltip": {
diff --git a/packages/neuron-wallet/src/controllers/app/index.ts b/packages/neuron-wallet/src/controllers/app/index.ts
index 888e087d19..30a0873f1a 100644
--- a/packages/neuron-wallet/src/controllers/app/index.ts
+++ b/packages/neuron-wallet/src/controllers/app/index.ts
@@ -132,6 +132,8 @@ export default class AppController {
         devTools: env.isDevMode,
         contextIsolation: false,
         preload: path.join(__dirname, './preload.js'),
+        // disable webSecurity for dev, do not set webSecurity as true, because electron has default set other value when webSecurity is not set by developer
+        ...(app.isPackaged ? {} : { webSecurity: false }),
       },
     })