Skip to content

Add to DefinitelyTyped #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psnider opened this issue Oct 4, 2015 · 3 comments
Open

Add to DefinitelyTyped #2

psnider opened this issue Oct 4, 2015 · 3 comments

Comments

@psnider
Copy link

psnider commented Oct 4, 2015

Have you submitted this to DefinitelyTyped?

This file looks good to me.
It just needs a test file.
I'll help if you like...

@yankee42
Copy link
Owner

yankee42 commented Oct 8, 2015

No, what do I need to do for that?
Feel free to create a pull request with the test file.

@maxime1992
Copy link

I think it would be a great idea to submit indeed !
The only definition I could find for SSE is yours ... :)
https://microsoft.github.io/TypeSearch/

And I've never published a type, but I think you just need to make a PR here : https://github.com/DefinitelyTyped/DefinitelyTyped It's explained in the readme.

@adumesny
Copy link

Yes it would be great as you are the only SSE typedef I could find as well...

surprised SSE is so hidden (I know IE is the only browser NOT supporting it, maybe why MSFT doesn't include in their DOM definition either (can't do 'if (window.EventSource) {...use EventSource} else { use long polling/polyfill}

I have made a few more tweaks as I'm starting to use it, which I can push back, like:

interface IOnMessageEvent extends Event {
data: string;
origin: string;
}
interface IOnErrorEvent extends Event {
target: IEventSourceStatic;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants