-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/config #3
Feat/config #3
Conversation
FreakyWizard
commented
Nov 14, 2024
•
edited
Loading
edited
- Created Config class and interface based on PHP CS Fixer variants
- Updated docs
- Installed array merger (don't reinvent the wheel)
- Wrote 18 tests
- Implemented new config with PHP CS Fixer
- Docs blocks for public functions
- Fixed github actions
- Fixed php version bugs
c120d13
to
d4de317
Compare
Composer package changes
|
cb98e84
to
a48b791
Compare
2392f4b
to
ed513ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nog een paar aanpassingen en daarna akkoord.
Zou je in de README bovenaan nog iets kunnen toevoegen in de trant van:
Dit zijn de php-cs-fixer rules die binnen het team WordPress gehanteerd worden voor sites en packages. Workflow voor auto commit kan je hier (linkje) vinden.
38e4381
to
1bd3018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ziet er goed! Ter info: Pest heeft een beforeEach hook waarmee code kunt uitvoeren die voor elke test moet plaats vinden: https://pestphp.com/docs/hooks