Skip to content

Commit 72ac00d

Browse files
authored
Adds GIT_AUTHOR_NAME to the test env (#6825)
## What's the problem this PR addresses? The test env doesn't automatically setup the git committer name / email. I noticed it when working on `yarn init`, as the test was passing but I didn't understand why until I dig deeper (turns out we don't pass the `strict` flag when calling the `git` commands; I don't remember whether it's an oversight or not). ## How did you fix it? Automatically setup the git committer name / email. Should a test want to avoid that (for example to explicitly test that a command works without), they should override it manually. ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
1 parent e65f166 commit 72ac00d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

packages/acceptance-tests/pkg-tests-core/sources/utils/makeTemporaryEnv.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ const mte = generatePkgDriver({
5656
[`YARN_PNP_FALLBACK_MODE`]: `none`,
5757
// Otherwise tests fail on systems where this is globally set to true
5858
[`YARN_ENABLE_GLOBAL_CACHE`]: `false`,
59+
// To make sure we can call Git commands
60+
[`GIT_AUTHOR_NAME`]: `John Doe`,
61+
[`GIT_AUTHOR_EMAIL`]: `[email protected]`,
62+
[`GIT_COMMITTER_NAME`]: `John Doe`,
63+
[`GIT_COMMITTER_EMAIL`]: `[email protected]`,
5964
// Older versions of Windows need this set to not have node throw an error
6065
[`NODE_SKIP_PLATFORM_CHECK`]: `1`,
6166
// We don't want the PnP runtime to be accidentally injected

0 commit comments

Comments
 (0)