fix: display query settings banner for non-default api call or txmode (#2152)

Author: astandrik

src/utils/hooks/useChangedQuerySettings.ts

@@ -14,15 +14,17 @@ export const useChangedQuerySettings = () => {
     const [lastQuerySettings] = useLastQueryExecutionSettings();
     const [currentQuerySettings] = useQueryExecutionSettings();
 
-    const changedLastExucutionSettings = lastQuerySettings
+    const changedLastExecutionSettings = lastQuerySettings
         ? getChangedQueryExecutionSettings(lastQuerySettings, DEFAULT_QUERY_SETTINGS)
         : [];
 
     const changedCurrentSettings = currentQuerySettings
         ? getChangedQueryExecutionSettings(currentQuerySettings, DEFAULT_QUERY_SETTINGS)
         : [];
 
-    const hasChangedLastExucutionSettings = changedLastExucutionSettings.length > 0;
+    const hasChangedImportantSettings =
+        changedLastExecutionSettings.includes('transactionMode') ||
+        changedLastExecutionSettings.includes('queryMode');
 
     const changedLastExecutionSettingsDescriptions = lastQuerySettings
         ? getChangedQueryExecutionSettingsDescription({
@@ -42,23 +44,21 @@ export const useChangedQuerySettings = () => {
         bannerLastClosedTimestamp &&
         Date.now() - bannerLastClosedTimestamp < WEEK_IN_SECONDS * 1000;
 
-    const isBannerShown = hasChangedLastExucutionSettings && !isClosedRecently;
-    const isIndicatorShown = hasChangedLastExucutionSettings && isClosedRecently;
+    const isBannerShown = hasChangedImportantSettings && !isClosedRecently;
 
     const closeBanner = () => setBannerLastClosedTimestamp(Date.now());
 
     const resetBanner = () => setBannerLastClosedTimestamp(undefined);
 
     return {
         isBannerShown,
-        isIndicatorShown,
         closeBanner,
         resetBanner,
 
         changedCurrentSettings,
         changedCurrentSettingsDescriptions,
 
-        changedLastExucutionSettings,
+        changedLastExecutionSettings,
         changedLastExecutionSettingsDescriptions,
     };
 };