Skip to content

Commit c840b21

Browse files
fix: fix wrong pdisk id order (#2170)
1 parent 7cefb6d commit c840b21

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

src/containers/PDiskPage/PDiskPage.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export function PDiskPage() {
128128
const handleAfterAction = () => {
129129
if (pDiskParamsDefined) {
130130
dispatch(
131-
api.util.invalidateTags([{type: 'PDiskData', id: getPDiskId(nodeId, pDiskId)}]),
131+
api.util.invalidateTags([{type: 'PDiskData', id: getPDiskId({nodeId, pDiskId})}]),
132132
'StorageData',
133133
);
134134
}
@@ -168,7 +168,7 @@ export function PDiskPage() {
168168
<EntityPageTitle
169169
entityName={pDiskPageKeyset('pdisk')}
170170
status={getSeverityColor(Severity)}
171-
id={getPDiskId(nodeId, pDiskId)}
171+
id={getPDiskId({nodeId, pDiskId})}
172172
/>
173173
<DecommissionLabel decommission={DecommitStatus} />
174174
</div>

src/store/reducers/pdisk/pdisk.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export const pDiskApi = api.injectEndpoints({
5757
'All',
5858
{
5959
type: 'PDiskData',
60-
id: getPDiskId(arg.nodeId, arg.pDiskId),
60+
id: getPDiskId({nodeId: arg.nodeId, pDiskId: arg.pDiskId}),
6161
},
6262
],
6363
}),

src/store/reducers/storage/prepareGroupsDisks.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ export function prepareGroupsPDisk(data: TStoragePDisk & {NodeId?: number} = {})
5757
};
5858

5959
const StringifiedId =
60-
bscPDisk.PDiskId || getPDiskId(mergedPDiskData.NodeId, mergedPDiskData.PDiskId);
60+
bscPDisk.PDiskId ||
61+
getPDiskId({nodeId: mergedPDiskData.NodeId, pDiskId: mergedPDiskData.PDiskId});
6162

6263
const {AllocatedPercent, AllocatedSize, AvailableSize, TotalSize} = preparePDiskSizeFields({
6364
AvailableSize: mergedPDiskData.AvailableSize,

src/utils/disks/helpers.ts

+7-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,13 @@ export function getColorSeverity(color?: EFlag) {
3434
return color ? DISK_COLOR_STATE_TO_NUMERIC_SEVERITY[color] : 0;
3535
}
3636

37-
export function getPDiskId(nodeId?: string | number | null, pDiskId?: string | number | null) {
37+
export function getPDiskId({
38+
nodeId,
39+
pDiskId,
40+
}: {
41+
nodeId?: string | number | null;
42+
pDiskId?: string | number | null;
43+
}) {
3844
if (valueIsDefined(nodeId) && valueIsDefined(pDiskId)) {
3945
return `${nodeId}-${pDiskId}`;
4046
}

src/utils/disks/prepareDisks.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export function prepareWhiteboardPDiskData(pdiskState: TPDiskStateInfo = {}): Pr
8787
...restPDiskFields
8888
} = pdiskState;
8989

90-
const StringifiedId = getPDiskId(PDiskId, NodeId);
90+
const StringifiedId = getPDiskId({nodeId: NodeId, pDiskId: PDiskId});
9191

9292
const Type = getPDiskType(Category);
9393

0 commit comments

Comments
 (0)