Skip to content

Commit 1093f07

Browse files
committed
Broken tests have been fixed
1 parent 5d1af4a commit 1093f07

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

internal/credentials/oauth2_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -621,9 +621,10 @@ func TestJWTTokenSourceReadPrivateKeyFromFile(t *testing.T) {
621621

622622
for _, method := range methods {
623623
for _, binary := range binaryOpts {
624-
f, err := os.CreateTemp("", "tmpfile-")
624+
f, err := os.CreateTemp(t.TempDir(), "tmpfile-")
625625
require.NoError(t, err)
626626
defer os.Remove(f.Name())
627+
defer f.Close()
627628

628629
var publicKey interface{}
629630
var src TokenSource
@@ -1018,12 +1019,12 @@ func TestParseSettingsFromFile(t *testing.T) {
10181019
for _, params := range testsParams {
10191020
var fileName string
10201021
if params.Cfg != "" {
1021-
f, err := os.CreateTemp("", "cfg-")
1022+
f, err := os.CreateTemp(t.TempDir(), "cfg-")
10221023
require.NoError(t, err)
10231024
defer os.Remove(f.Name())
1025+
defer f.Close()
10241026
_, err = f.WriteString(params.Cfg)
10251027
require.NoError(t, err)
1026-
f.Close()
10271028
fileName = f.Name()
10281029
} else {
10291030
fileName = params.CfgFile

with_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,12 @@ func TestWithCertificatesCached(t *testing.T) {
4949
Bytes: caBytes,
5050
})
5151
require.NoError(t, err)
52-
f, err := os.CreateTemp("", "ca.pem")
52+
f, err := os.CreateTemp(os.TempDir(), "ca.pem")
53+
defer os.Remove(f.Name())
54+
defer f.Close()
5355
require.NoError(t, err)
5456
_, err = f.Write(caPEM.Bytes())
5557
require.NoError(t, err)
56-
defer os.Remove(f.Name())
5758

5859
var (
5960
n = 100

0 commit comments

Comments
 (0)