Skip to content

Commit 42ca696

Browse files
authored
Merge pull request #1311 from ydb-platform/fix-nil-pointer-dereference
Fix nil pointer dereference when closing result set.
2 parents 08c3ba6 + e7386da commit 42ca696

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
* Fixed nil pointer dereference when closing result set
2+
13
## v3.74.4
24
* Fixed bug with fail cast of grpc response to `operation.{Response,Status}`
35

internal/query/client.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,15 +231,15 @@ func clientExecute(ctx context.Context,
231231
q string, opts ...options.ExecuteOption,
232232
) (r query.Result, err error) {
233233
err = do(ctx, pool, func(ctx context.Context, s query.Session) (err error) {
234-
_, r, err = s.Execute(ctx, q, opts...)
234+
_, streamResult, err := s.Execute(ctx, q, opts...)
235235
if err != nil {
236236
return xerrors.WithStackTrace(err)
237237
}
238238
defer func() {
239-
_ = r.Close(ctx)
239+
_ = streamResult.Close(ctx)
240240
}()
241241

242-
r, err = resultToMaterializedResult(ctx, r)
242+
r, err = resultToMaterializedResult(ctx, streamResult)
243243
if err != nil {
244244
return xerrors.WithStackTrace(err)
245245
}

0 commit comments

Comments
 (0)