From 2ef6894b7249afda88c8be6a9ec1ca51da292ca1 Mon Sep 17 00:00:00 2001 From: size12 Date: Sun, 4 Feb 2024 12:47:56 +0300 Subject: [PATCH 1/2] fixed flaky tests --- CHANGELOG.md | 1 + internal/xtest/waiters.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 86c81bc7f..b4f66d60c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ +* Fixed flaky `xtest.SpinWaitCondition` * Fixed topic writer infinite reconnections in some cases * Refactored nil on err `internal/grpcwrapper/rawydb/issues.go`, when golangci-lint nilerr enabled * Refactored nil on err `internal/grpcwrapper/rawtopic/describe_topic.go`, when golangci-lint nilerr enabled diff --git a/internal/xtest/waiters.go b/internal/xtest/waiters.go index 34389c1c0..e58c25688 100644 --- a/internal/xtest/waiters.go +++ b/internal/xtest/waiters.go @@ -9,7 +9,7 @@ import ( "github.com/ydb-platform/ydb-go-sdk/v3/internal/empty" ) -const commonWaitTimeout = time.Second +const commonWaitTimeout = 5 * time.Second func WaitGroup(tb testing.TB, wg *sync.WaitGroup) { tb.Helper() From 47b6cdfaabd7023de3cc4654ce15ab55688a7537 Mon Sep 17 00:00:00 2001 From: size12 Date: Sun, 4 Feb 2024 13:00:13 +0300 Subject: [PATCH 2/2] edited changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b4f66d60c..4d73381bf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -* Fixed flaky `xtest.SpinWaitCondition` +* Fixed flaky tests which use `xtest.SpinWaitCondition` * Fixed topic writer infinite reconnections in some cases * Refactored nil on err `internal/grpcwrapper/rawydb/issues.go`, when golangci-lint nilerr enabled * Refactored nil on err `internal/grpcwrapper/rawtopic/describe_topic.go`, when golangci-lint nilerr enabled