Merge pull request #49 from shashkin/remove-double-quoting

gridnevvvit · web-flow · commit 36593948888f · 2022-09-11T21:06:09.000+03:00
Avoid double-quoting of identifiers
diff --git a/ydb/sqlalchemy/__init__.py b/ydb/sqlalchemy/__init__.py
@@ -37,8 +37,8 @@ def __init__(self, dialect):
             )
 
         def _requires_quotes(self, *args, **kwargs):
-            # Force all identifiers to get quoted.
-            return True
+            # Force all identifiers to get quoted unless already quoted.
+            return not (value.startswith(self.initial_quote) and value.endswith(self.final_quote))
 
     class YqlTypeCompiler(GenericTypeCompiler):
         def visit_VARCHAR(self, type_, **kw):

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,8 @@ def __init__(self, dialect):`
`37`	`37`	`)`
`38`	`38`
`39`	`39`	`def _requires_quotes(self, args, *kwargs):`
`40`		`- # Force all identifiers to get quoted.`
`41`		`- return True`
	`40`	`+ # Force all identifiers to get quoted unless already quoted.`
	`41`	`+ return not (value.startswith(self.initial_quote) and value.endswith(self.final_quote))`
`42`	`42`
`43`	`43`	`class YqlTypeCompiler(GenericTypeCompiler):`
`44`	`44`	`def visit_VARCHAR(self, type_, **kw):`