Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Allow Entity IDs to be string-valued types #21

Closed
nvamelichev opened this issue Feb 5, 2024 · 2 comments
Closed

Experimental: Allow Entity IDs to be string-valued types #21

nvamelichev opened this issue Feb 5, 2024 · 2 comments
Assignees
@nvamelichev
Labels
bug Something isn't working

Comments

@nvamelichev
Copy link
Collaborator

This almost works already, except when matching entities by ID using in-memory table: this relies on EntityIdSchema.compare(ID, ID) which is inconsistent with ID.equals() in case of string-valued types. We should compare IDs as their toString() values and not their components in this case.
nvamelichev added a commit that referenced this issue Feb 6, 2024
@nvamelichev
#21: EXPERIMENTAL: Allow Entity IDs to be String-valued types
54888fb 
...represented as string values in YDB and marshaled using valueOf()/fromString() and toString() methods.

To enable this experimental feature, set EntityIdSchema.allowStringValuedTypesAsEntityIds flag to true
and then register your ID as a string-valued type using FieldValueType.registerStringValueType().
@nvamelichev nvamelichev self-assigned this Feb 7, 2024
nvamelichev added a commit that referenced this issue Feb 8, 2024
@nvamelichev
#21: EXPERIMENTAL: Allow Entity IDs to be String-valued types
3d97e1d 
...represented as string values in YDB and marshaled using `valueOf()`/`fromString()`
and `toString()`` methods.

To enable this experimental feature, annotate your ID type with `@StringValueType(entityId=true)`.
nvamelichev added a commit that referenced this issue Feb 15, 2024
@nvamelichev
#21: EXPERIMENTAL: Allow Entity IDs to be String-valued types
14f61c1 
...represented as string values in YDB and marshaled using `valueOf()`/`fromString()`
and `toString()`` methods.

To enable this experimental feature, annotate your ID type with `@StringValueType(entityId=true)`.
@nvamelichev
Copy link
Collaborator Author

Prototyping in
#22

nvamelichev added a commit that referenced this issue Feb 19, 2024
@nvamelichev
#21: EXPERIMENTAL: Allow Entity IDs to be String-valued types
7fb57a9 
...represented as string values in YDB and marshaled using `valueOf()`/`fromString()`
and `toString()`` methods.

To enable this experimental feature, annotate your ID type with `@StringValueType(entityId=true)`.
@nvamelichev
Copy link
Collaborator Author

Closed in favor of #24

nvamelichev added a commit that referenced this issue Feb 29, 2024
@nvamelichev
#21: EXPERIMENTAL: Field Conversion Improvements (#22)
8d1d38d 
**This PR brings an experimental feature**, explicitly annotated as
`@ExperimentalApi`:

Adding arbitrary converters between Java values and DB-compatible
"column values", using new `@CustomValueType` annotation either on the
type, or inside `@Column` annotation on the entity field.

These "custom value types" can even be used inside IDs, if their
converters transform field value into a ID-compatible value (a String, a
enum, an integer, a timestamp, a boolean value or a byte array).

This feature has the potential to replace all ad-hoc "string-value type"
functionality in the future.
@lavrukov lavrukov added the bug Something isn't working label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvamelichev nvamelichev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nvamelichev @lavrukov