ignore inline source maps

Author: nelsonpecora

tasks/filerev.js

@@ -6,7 +6,6 @@ var chalk = require('chalk');
 var eachAsync = require('each-async');
 var convert = require('convert-source-map');
 
-
 module.exports = function (grunt) {
   grunt.registerMultiTask('filerev', 'File revisioning based on content hashing', function () {
     var target = this.target;
@@ -88,8 +87,9 @@ module.exports = function (grunt) {
             }
             // rewrite the sourceMappingURL in files
             var fileContents = grunt.file.read(resultPath, {encoding: 'utf8'});
+            // use regex that matches single-line and multi-line sourcemap urls
+            // note: this will ignore inline base64-encoded sourcemaps
             var matches = convert.mapFileCommentRegex.exec(fileContents);
-            // var sourceMapComment = matches[0]; // full comment
             var sourceMapFile = matches[1] || matches[2]; // 1st is single line, 2nd is multiline
             var newSrcMap = fileContents.replace(sourceMapFile, path.basename(resultPathMap));
             grunt.file.write(resultPath, newSrcMap, {encoding: 'utf8'});

test/fixtures/inline.js

@@ -11,6 +11,7 @@ var hashes = {
   'test/fixtures/styles.css' : 'test/tmp/withSourceMaps/styles.a6aa2292.css',
   'test/fixtures/styles.css.map' : 'test/tmp/withSourceMaps/styles.a6aa2292.css.map',
   'test/fixtures/more-styles.css' : 'test/tmp/withSourceMaps/more-styles.dce8e0e5.css',
+  'test/fixtures/inline.js' : 'test/tmp/withSourceMaps/inline.8b435ef2.js',
   'test/fixtures/another.png' : 'test/tmp/another-processed-92279d3f.png'
 };
 
@@ -84,6 +85,13 @@ it('should revision .css file ok without any .map', function () {
   assert(revisioned === original);
 });
 
+it('should ignore inline base64-encoded sourcemaps', function () {
+  var file = 'test/fixtures/inline.js';
+  var original = fs.statSync(file).size;
+  var revisioned = fs.statSync(hashes[file]).size;
+  assert(revisioned === original);
+});
+
 it('should allow a filename processing function', function () {
   var file = 'test/fixtures/another.png';
   var original = fs.statSync(file).size;