You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
when creating previews, the command doesn’t include a display-name value: sh -c "aws amplify start-job --app-id=${AmplifyAppId} --branch-name=$BRANCH_NAME --job-type=RELEASE --region=${AWS_REGION}", so essentially its aws amplify choosing a display name (prefix of the url) for it, and in the end, the script post the url it think aws amplify creates with the following line:
if [ -z "$GITHUB_TOKEN" ] ; then
echo "Skipping comment as GITHUB_TOKEN not provided"
else
SUBDOMAIN_NAME=$(echo $BRANCH_NAME | sed 's/[^a-zA-Z0-9-]/-/')
curl -X POST $COMMENT_URL -H "Content-Type: application/json" -H "Authorization: token $GITHUB_TOKEN" --data '{ "body": "'"Preview branch generated at https://$SUBDOMAIN_NAME.${AmplifyAppId}.amplifyapp.com"'" }'
fi
To Reproduce
Getting a branch with underscore and dash in the name and open a PR with it.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: [e.g. Mac/Windows/Ubuntu]
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Describe the bug
when creating previews, the command doesn’t include a display-name value:
sh -c "aws amplify start-job --app-id=${AmplifyAppId} --branch-name=$BRANCH_NAME --job-type=RELEASE --region=${AWS_REGION}"
, so essentially its aws amplify choosing a display name (prefix of the url) for it, and in the end, the script post the url it think aws amplify creates with the following line:To Reproduce
Getting a branch with underscore and dash in the name and open a PR with it.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: