Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What would be a good way to exclude styles-l from the preloads? #33

Open
jellesiderius opened this issue Jan 31, 2022 · 2 comments
Open

Comments

@jellesiderius
Copy link

jellesiderius commented Jan 31, 2022

Hi Jisse,

Thanks for creating and maintaining this great Magento module! We're facing one small issue for mobile users where the styles-l gets preloaded while this is not really necessary to download on a mobile device. Do you think it would be a good idea to exclude the styles-l from preloading on mobile? Maybe it would be nice if we can make this configurable and be able to whitelist a couple of files through the settings?

@jissereitsma
Copy link
Collaborator

I didn't actually think of this. I don't see myself as an ideal expert on performance. So I don't know whether it is better to preload the styles-l stylesheet for all devices while not needed on mobile, or to not preload the styles-l stylesheet at all. But it might also depend on the sizes of the files. Perhaps it is best to allow for this to be configured. Unfortunately, there is no conditional preloading possible (aka: preload something depending on media queries or something).

@JelleGe
Copy link

JelleGe commented Jun 1, 2023

Is there any update on this 'issue'?

We use a custom theme (child-theme) for mobile, where we want to exclude the styles-l being preload.
Is there a setting in the module, to exclude a specific file to be preloaded?

In that case we can only load this in our mobile theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants