Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsuite] Issue with base64_encoded image used as return of a controller #37

Open
romainruaud opened this issue Apr 5, 2022 · 1 comment

Comments

@romainruaud
Copy link

Hi,

it has been reported to Elasticsuite that this extension might causes some issues on the tracking pixel url of Elasticsuite.

Since this image is generated as base64 encoded result of a layoutless controller, this might be an edge-case your module is not covering.

Or maybe we could just add some sort of one-liner by our side to allow proper compliance between our two modules.

Let us know

You can check this comment which is well detailed : Smile-SA/elasticsuite#2393 (comment)

Regards

@jissereitsma
Copy link
Collaborator

Thanks for posting the issue. I find the original thread quite hard to follow, with conclusions made early, traces being typed down instead of actual dumps, and a problem description that does not actually seem to hit the issue. However, without trying to duplicate this myself, I can "guess" that the problem might be the LinkPreload module reacting upon the response, assuming it is an HTML-like response, while it is actually not. I've added a new release 1.4.16 to improve this. If that version could be checked up upon, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants