Change ages indexation approach

[duozersk]

Currently we are indexing from min age to max age with the 6 months steps.

https://github.com/ymcatwincities/openy_activity_finder/blob/4.x/src/Plugin/search_api/processor/AgesMinMax.php#L67

It has several flaws:

• assumes that the min age is dividable by 6 (6, 12, 18, etc. in months); but it really can be anything like 9 months or so - and we will be indexing values like 9, 15, 21 months - and these values will not work with the age filter values
• we should change it to index the ages present in the ages config (and only these ages) - https://github.com/ymcatwincities/openy_activity_finder/blob/4.x/config/install/openy_activity_finder.settings.yml#L4

[podarok]

@KylieAldridge for the Jira

[shelleygoetz]

Jira ticket: https://openy.atlassian.net/browse/PRODDEV-515

[podarok]

merged, this one should be fixed now

@duozersk is there any test we can use for QA?

[duozersk]

Well... testing it is quite cumbersome.

We should have the session/activity (either in demo content or create manually) with the min age set to smth that is not dividable by 6 (in months). Like from min age 15 months to max age 36 months. The code before the fix would index 15, 21, 27 and 33 months into the search index for this activity and this session wouldn't be there in the results for any of the age filters (as the ages configuration doesn't have these numbers). The new version of code would index 18, 24 and 36 months - based on the ages configuration - and the activity will be there in the results in you select appropriate age filter.

Ages configuration is this one - https://github.com/ymcatwincities/openy_activity_finder/blob/4.x/config/install/openy_activity_finder.settings.yml#L4

[froboy]

I installed openy_prgf_af4_demo on 4.0.9 and got this error right off the bat:

Drupal\search_api_solr\SearchApiSolrException: Facets having a mincount of "0" is not yet supported by Solr for point based field types. Consider converting the following field to a string or index it twice as string: field_session_min_age. in Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend->setFacets() (line 3552 of modules/contrib/search_api_solr/src/Plugin/search_api/backend/SearchApiSolrBackend.php).

Once I updated to 4.x-dev the issue was resolved and the error gone. I think we should be good to tag a new release with this fix since AF4 on 4.0.9 seems broken.

[podarok]

Yes, we need to tag a new release @froboy
It's war slowed down me a bit.