Skip to content

Commit 0f2bb9b

Browse files
authored
Use greater than or equal to in version comparisons for peft (huggingface#5785)
1 parent 28d70f1 commit 0f2bb9b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

utils/constants.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222

2323
default_cache_path = HUGGINGFACE_HUB_CACHE
2424

25-
MIN_PEFT_VERSION = "0.5.0"
26-
MIN_TRANSFORMERS_VERSION = "4.33.3"
25+
MIN_PEFT_VERSION = "0.6.0"
26+
MIN_TRANSFORMERS_VERSION = "4.34.0"
2727

2828

2929
CONFIG_NAME = "config.json"
@@ -41,12 +41,12 @@
4141
# Below should be `True` if the current version of `peft` and `transformers` are compatible with
4242
# PEFT backend. Will automatically fall back to PEFT backend if the correct versions of the libraries are
4343
# available.
44-
# For PEFT it is has to be greater than 0.6.0 and for transformers it has to be greater than 4.33.1.
44+
# For PEFT it is has to be greater than or equal to 0.6.0 and for transformers it has to be greater than or equal to 4.34.0.
4545
_required_peft_version = is_peft_available() and version.parse(
4646
version.parse(importlib.metadata.version("peft")).base_version
47-
) > version.parse(MIN_PEFT_VERSION)
47+
) >= version.parse(MIN_PEFT_VERSION)
4848
_required_transformers_version = is_transformers_available() and version.parse(
4949
version.parse(importlib.metadata.version("transformers")).base_version
50-
) > version.parse(MIN_TRANSFORMERS_VERSION)
50+
) >= version.parse(MIN_TRANSFORMERS_VERSION)
5151

5252
USE_PEFT_BACKEND = _required_peft_version and _required_transformers_version

0 commit comments

Comments
 (0)