【Help】Panic when call Close(), May be bug?

[wwhai]

This is my lua code:

function Main(arg)
	while true do
		print("Hello World")
	end
	return 0
end

I run a simple lua file contains a unified loop, When I call Close(), the program will panic, error in line -> 1390。Please help me resoleve this problem

Unit test:

func Test_loop_close(t *testing.T) {
	var s1 = `
		function f()
			while true do
			print("Hello World")
			end
		end
		f()
	`
	var luaVM = lua.NewState()
	go func() {
		err1 := luaVM.DoString(s1)
		if err1 != nil {
			panic(err1)
		}
	}()
	time.Sleep(3 * time.Second)
	luaVM.Close()
}

Panic log:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]      
        panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x50 pc=0xb1a892]

goroutine 16 [running]:
github.com/yuin/gopher-lua.(*LState).PCall.func1()
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/state.go:2020 +0x532
panic({0x1608280, 0x145c120})
        C:/Program Files/Go/src/runtime/panic.go:884 +0x213
github.com/yuin/gopher-lua.callGFunction(0xc0000ad6b0, 0x0)
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/vm.go:262 +0x2f9
github.com/yuin/gopher-lua.init.3.func26(0xc0000ad6b0, 0x18000000?, 0xc000681000?)       
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/vm.go:821 +0x379
github.com/yuin/gopher-lua.mainLoop(0xc0000ad6b0, 0xc0000ec600?)
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/vm.go:31 +0xfa
github.com/yuin/gopher-lua.(*LState).callR(0xc0000ad6b0, 0x0, 0xffffffffffffffff, 0xc000117f38?)
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/state.go:1211 +0x1b4
github.com/yuin/gopher-lua.(*LState).Call(...)
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/state.go:1967
github.com/yuin/gopher-lua.(*LState).PCall(0xc0000ad6b0, 0x0, 0xc0000ec600?, 0x0)        
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/state.go:2030 +0x145
github.com/yuin/gopher-lua.(*LState).DoString(0xc0000ad6b0, {0x18c04d2?, 0x0?})
        C:/Users/admin/go/pkg/mod/github.com/yuin/[email protected]/auxlib.go:405 +0x6b
github.com/i4de/rulex/test.Test_loop_close.func1()
        C:/Users/admin/workspace/rulex/test/calllua_test.go:172 +0x25
created by github.com/i4de/rulex/test.Test_loop_close
        C:/Users/admin/workspace/rulex/test/calllua_test.go:171 +0x7d
FAIL    github.com/i4de/rulex/test      3.260s
FAIL

[wwhai]

I have found reason:

[wwhai]

It is a concurrency race problem, because run script with a go routine but close it by another. I think should expose callFrameStack to user, because can use setCallFrameStack(callFrameStack) to break loop but no PANIC.

This is Example ：

func (ls *LState) Close() {
	atomic.AddInt32(&ls.stop, 1)
	for _, file := range ls.G.tempFiles {
		// ignore errors in these operations
		file.Close()
		os.Remove(file.Name())
	}
	ls.stack.Push(callFrame{
		Fn:         goto_end_func,
		Pc:         0,
		Base:       0,
		LocalBase:  0,
		ReturnBase: 0,
		NArgs:      0,
		NRet:       0,
		Parent:     nil,
		TailCall:   0,
	})
	ls.stack.FreeAll()
	ls.stack = nil
}

The goto_end_func function can like this:

function __() end __()

[wwhai]

What usage of kill function?

I noticed this function is not called by other

[cloudwindy]

This is not a bug. Do not use one LState for multiple goroutines as pointed out in README.md.

[wwhai]

but actually I need multiple goroutine to handle one LState