コンパイル時にwarningがあるときはCIをfailにしたい #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

laysakura opened this issue May 4, 2021 · 1 comment · Fixed by #57

Labels

コメントを募集全体方針

Collaborator

laysakura commented May 4, 2021 •

edited

Loading

#35 (comment)
このあたりのをCIで防ぎたい。

% RUSTFLAGS='-D warnings' cargo build --all-targets --all-features

でできるはず。

laysakura added コメントを募集全体方針管理系 and removed 管理系 labels

laysakura mentioned this issue

ci: ビルド警告でCI failするようにした & ビルド対象を all-targets , all-featurs にした。 #57

Merged

Owner

yuk1ty commented May 4, 2021

導入しましょう！

意図的に警告をスルーしたい場合は allow attribute を明示的に書いてもらうという運用で十分そうですしね。

yuk1ty closed this as completed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment