Better (shorter) error message when handling invalid XML

Author: ggrossetie

Diff for: .github/workflows/release.yml

@@ -4,6 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       tag:
+        description: tag
         required: true
 
 run-name: Native Images ${{ inputs.tag }} by @${{ github.actor }}

Diff for: umlet-cli/pom.xml

@@ -14,13 +14,24 @@
   </properties>
 
   <artifactId>umlet</artifactId>
+  <name>umlet-cli</name>
 
   <dependencies>
     <dependency>
       <groupId>com.umlet</groupId>
       <artifactId>umlet-mini</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+      <version>2.0.7</version>
+    </dependency>
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-classic</artifactId>
+      <version>1.4.7</version>
+    </dependency>
   </dependencies>
 
   <build>

Diff for: umlet-cli/src/main/java/io/kroki/umlet/UmletConverter.java

@@ -6,6 +6,7 @@
 import com.baselet.control.util.Utils;
 import com.baselet.diagram.DiagramHandler;
 import com.baselet.diagram.io.OutputHandler;
+import org.xml.sax.SAXParseException;
 
 import java.io.BufferedReader;
 import java.io.ByteArrayOutputStream;
@@ -22,11 +23,20 @@ public class UmletConverter {
   }
 
   public static byte[] convert(String source, String outputFormat) throws Exception {
-    DiagramHandler handler = DiagramHandler.forExport(source);
-    ByteArrayOutputStream baos = new ByteArrayOutputStream();
-    OutputHandler.createToStream(outputFormat, baos, handler);
-    byte[] result = baos.toByteArray();
-    handler.close();
-    return result;
+    try {
+      DiagramHandler handler = DiagramHandler.forExport(source);
+      ByteArrayOutputStream baos = new ByteArrayOutputStream();
+      OutputHandler.createToStream(outputFormat, baos, handler);
+      byte[] result = baos.toByteArray();
+      handler.close();
+      return result;
+    } catch (Exception e) {
+      if (e instanceof RuntimeException && e.getCause() instanceof SAXParseException) {
+        // gives a better error message when handling invalid XML
+        // https://github.com/yuzutech/kroki/issues/1556
+        throw new IllegalArgumentException(e.getCause().getMessage());
+      }
+      throw e;
+    }
   }
 }

Diff for: umlet-cli/src/main/resources/logback.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!DOCTYPE configuration>
+
+<configuration>
+    <import class="ch.qos.logback.classic.encoder.PatternLayoutEncoder"/>
+    <import class="ch.qos.logback.core.ConsoleAppender"/>
+
+    <appender name="STDOUT" class="ConsoleAppender">
+        <encoder class="PatternLayoutEncoder">
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} -%kvp- %msg%n</pattern>
+        </encoder>
+    </appender>
+
+    <root level="WARN">
+        <appender-ref ref="STDOUT"/>
+    </root>
+</configuration>