Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension prevents adding a review comment with ctrl+enter #1486

Open
MikaelStave opened this issue Nov 28, 2024 · 0 comments
Open

Extension prevents adding a review comment with ctrl+enter #1486

MikaelStave opened this issue Nov 28, 2024 · 0 comments

Comments

@MikaelStave
Copy link

What's the problem

When doing a code review in VSCode and you are focued in the "Comment" you can't add the review comment with the shortcut ctrl+enter. Came down to this extension after doing a extension bisect. It also didn't seem like I could rebind the shortcut from the github pull request extension forcing me to disable this extension.

What's the expected result

You should be able to add a review comment with the shortcut and this extension should not prevent it.

How to reproduce

  1. Checkout a pull request.
  2. Start writing a review comment.
  3. Try to add the comment with the ctrl+enter

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant