Merge pull request philc#945 from shyiko/master

Fixed detection of links which are only partially inside the viewport

Author: philc

lib/dom_utils.coffee

@@ -46,11 +46,21 @@ DomUtils =
   #
   getVisibleClientRect: (element) ->
     # Note: this call will be expensive if we modify the DOM in between calls.
-    clientRects = element.getClientRects()
+    clientRects = ({
+      top: clientRect.top, right: clientRect.right, bottom: clientRect.bottom, left: clientRect.left,
+      width: clientRect.width, height: clientRect.height
+    } for clientRect in element.getClientRects())
 
     for clientRect in clientRects
-      if (clientRect.top < -2 || clientRect.top >= window.innerHeight - 4 ||
-          clientRect.left < -2 || clientRect.left  >= window.innerWidth - 4)
+      if (clientRect.top < 0)
+        clientRect.height += clientRect.top
+        clientRect.top = 0
+
+      if (clientRect.left < 0)
+        clientRect.width += clientRect.left
+        clientRect.left = 0
+
+      if (clientRect.top >= window.innerHeight - 4 || clientRect.left  >= window.innerWidth - 4)
         continue
 
       if (clientRect.width < 3 || clientRect.height < 3)

tests/dom_tests/dom_utils_test.coffee

@@ -42,6 +42,14 @@ context "Check visibility",
     assert.equal null, DomUtils.getVisibleClientRect document.getElementById 'foo'
     assert.equal null, DomUtils.getVisibleClientRect document.getElementById 'bar'
 
+  should "detect links only partially outside viewport as visible", ->
+    document.getElementById("test-div").innerHTML = """
+    <a id='foo' style='position:absolute;top:-10px'>test</a>
+    <a id='bar' style='position:absolute;left:-10px'>test</a>
+    """
+    assert.isTrue (DomUtils.getVisibleClientRect document.getElementById 'foo') != null
+    assert.isTrue (DomUtils.getVisibleClientRect document.getElementById 'bar') != null
+
   should "detect opacity:0 links as hidden", ->
     document.getElementById("test-div").innerHTML = """
     <a id='foo' style='opacity:0'>test</a>

tests/unit_tests/utils_test.coffee

@@ -1,5 +1,7 @@
 require "./test_helper.js"
 extend(global, require "../../lib/utils.js")
+Utils.getCurrentVersion = -> '1.43'
+global.localStorage = {}
 extend(global, require "../../background_scripts/settings.js")
 
 context "isUrl",