Skip to content

Commit b1c58ea

Browse files
committed
Fixes for MR comments
Signed-off-by: Matt Plachter <[email protected]> redirect to contrib url fix spelling error remove commented out code
1 parent e85c22f commit b1c58ea

File tree

3 files changed

+12
-16
lines changed

3 files changed

+12
-16
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ See [Installation Docs](https://tfbuddy.readthedocs.io/en/stable/usage/)
2929

3030
## Contributing
3131

32-
The [contributing](./docs/contributing.md) has everything you need to start working on TFBuddy.
32+
The [contributing](https://tfbuddy.readthedocs.io/en/stable/contributing/) has everything you need to start working on TFBuddy.
3333

3434

3535
## Documentation

pkg/comment_actions/parsing.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
var (
1515
ErrNotTFCCommand = errors.New("not a TFC command")
1616
ErrOtherTFTool = errors.New("use 'tfc' to interact with tfbuddy")
17-
ErrNoNotePassed = errors.New("no notes passed in not block")
17+
ErrNoNotePassed = errors.New("no notes passed in note block")
1818
ErrInvalidAction = errors.New("invalid tfc action")
1919
)
2020

pkg/mocks/helpers.go

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,11 @@ type TestMetaData struct {
119119
TFBuddyConfig []byte
120120
}
121121
type TestSuite struct {
122-
MockGitClient *MockGitClient
123-
MockGitMR *MockDetailedMR
124-
MockGitRepo *MockGitRepo
125-
MockGitDisc *MockMRDiscussionNotes
126-
MockMRNote *MockMRNote
127-
// MockTriggerConfig *MockTriggerConfig
122+
MockGitClient *MockGitClient
123+
MockGitMR *MockDetailedMR
124+
MockGitRepo *MockGitRepo
125+
MockGitDisc *MockMRDiscussionNotes
126+
MockMRNote *MockMRNote
128127
MockApiClient *MockApiClient
129128
MockStreamClient *MockStreamClient
130129
MockProject *MockProject
@@ -211,21 +210,18 @@ func CreateTestSuite(mockCtrl *gomock.Controller, overrides TestOverrides, t *te
211210
mockGitDisc := NewMockMRDiscussionNotes(mockCtrl)
212211
mockMRNote := NewMockMRNote(mockCtrl)
213212

214-
// mockTriggerConfig := NewMockTriggerConfig(mockCtrl)
215-
216213
mockApiClient := NewMockApiClient(mockCtrl)
217214

218215
mockStreamClient := NewMockStreamClient(mockCtrl)
219216

220217
mockProject := NewMockProject(mockCtrl)
221218

222219
return &TestSuite{
223-
MockGitClient: mockGitClient,
224-
MockGitMR: mockGitMR,
225-
MockGitRepo: mockGitRepo,
226-
MockGitDisc: mockGitDisc,
227-
MockMRNote: mockMRNote,
228-
// MockTriggerConfig: mockTriggerConfig,
220+
MockGitClient: mockGitClient,
221+
MockGitMR: mockGitMR,
222+
MockGitRepo: mockGitRepo,
223+
MockGitDisc: mockGitDisc,
224+
MockMRNote: mockMRNote,
229225
MockApiClient: mockApiClient,
230226
MockStreamClient: mockStreamClient,
231227
MockProject: mockProject,

0 commit comments

Comments
 (0)