update how inline references are handled v2

Author: Mikejmnez

virtualizarr/parsers/dmrpp.py

@@ -1,3 +1,4 @@
+import base64
 import io
 import warnings
 from pathlib import Path
@@ -15,7 +16,6 @@
     ManifestGroup,
     ManifestStore,
 )
-from virtualizarr.manifests.manifest import ChunkEntry
 from virtualizarr.manifests.utils import create_v3_array_metadata
 from virtualizarr.parsers.utils import encode_cf_fill_value
 
@@ -198,13 +198,23 @@ def parse_dataset(
                 meta["attributes"]["_FillValue"] = encoded_cf_fill_value
 
             if "inline" in meta:
-                # chunkmanifest is empty - extract inline data from dict
+                # extract data already decoded into array/string
                 data = meta.pop("inline", None)
-                shape = meta.pop("shape", None)
-                chunk_entry = ChunkEntry(
-                    path="__inlined__", offset=0, length=len(data), data=data
-                )
-                chunkmanifest = ChunkManifest(entries=chunk_entry, shape=shape)
+                bdata = base64.b64encode(data)
+                # chunk_entry = ChunkEntry(
+                #     path="", offset=0, length=len(bdata), data=bdata
+                # )
+                # chunkmanifest = ChunkManifest(entries=chunk_entry)
+
+                chunks = {
+                    "0.0": {
+                        "path": "__inline__",
+                        "offset": 0,
+                        "length": len(bdata),
+                        "data": bdata,
+                    },
+                }
+                chunkmanifest = ChunkManifest(entries=chunks)
             else:
                 chunkmanifest = ChunkManifest(chunkmanifest)
 

virtualizarr/tests/test_parsers/test_dmrpp.py

@@ -564,16 +564,21 @@ def test_dmrpp_missing_attrib_validation(dmrpp_xml_with_missing_attrib):
     assert manifest_store._group is not None
 
 
-@pytest.mark.xfail(
-    reason="inline reference is failing locally",
-)
 @requires_network
 def test_inlinevalue():
+    """
+    Test that inline values can be parsed into manifest
+    """
+    expected_bytes = b"AAAAAAAAAAABAAAAAAAAAAIAAAAAAAAAAwAAAAAAAAAEAAAAAAAAAAUAAAAAAAAABgAAAAAAAAAHAAAAAAAAAAgAAAAAAAAACQAAAAAAAAA="
+
     dmrpp_file = (
         "http://test.opendap.org/opendap/data/dmrpp/compact_lowlevel.h5.dmrpp.file"
     )
     session = requests.Session()
     dmrpp = session.get(dmrpp_file).content.decode()
     parser = dmrparser(dmrpp, filepath="file:///")
     store = obstore_local(url=parser.data_filepath)
-    parser.parse_dataset(object_store=store)
+    ms = parser.parse_dataset(object_store=store)
+    vds = ms.to_virtual_dataset()
+    assert "my_dataset" in vds
+    assert ms._group["my_dataset"]._manifest._inlined == {(0, 0): expected_bytes}