Update to zcash/zcash_note_encryption@1dbc8b2f7b96519706ca2ea8322dcfeea76eef3e

nuttycom · nuttycom · commit 616073cdd62e · 2025-06-11T13:43:13.000-06:00
This adapts the `zcash_note_encryption::ShieldedOutput` impl's provided
by this crate to include implementations of the newly added `cmstar()`
method.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -106,3 +106,6 @@ debug = true
 
 [profile.bench]
 debug = true
+
+[patch.crates-io]
+zcash_note_encryption = { git = "https://git@github.com/zcash/zcash_note_encryption", rev = "1dbc8b2f7b96519706ca2ea8322dcfeea76eef3e" }
diff --git a/src/note_encryption.rs b/src/note_encryption.rs
@@ -265,8 +265,8 @@ impl<T> ShieldedOutput<OrchardDomain, ENC_CIPHERTEXT_SIZE> for Action<T> {
         EphemeralKeyBytes(self.encrypted_note().epk_bytes)
     }
 
-    fn cmstar_bytes(&self) -> [u8; 32] {
-        self.cmx().to_bytes()
+    fn cmstar(&self) -> &<OrchardDomain as Domain>::ExtractedCommitment {
+        self.cmx()
     }
 
     fn enc_ciphertext(&self) -> &[u8; ENC_CIPHERTEXT_SIZE] {
@@ -279,8 +279,8 @@ impl ShieldedOutput<OrchardDomain, ENC_CIPHERTEXT_SIZE> for crate::pczt::Action
         EphemeralKeyBytes(self.output().encrypted_note().epk_bytes)
     }
 
-    fn cmstar_bytes(&self) -> [u8; 32] {
-        self.output().cmx().to_bytes()
+    fn cmstar(&self) -> &<OrchardDomain as Domain>::ExtractedCommitment {
+        self.output().cmx()
     }
 
     fn enc_ciphertext(&self) -> &[u8; ENC_CIPHERTEXT_SIZE] {
@@ -321,8 +321,8 @@ impl ShieldedOutput<OrchardDomain, COMPACT_NOTE_SIZE> for CompactAction {
         EphemeralKeyBytes(self.ephemeral_key.0)
     }
 
-    fn cmstar_bytes(&self) -> [u8; 32] {
-        self.cmx.to_bytes()
+    fn cmstar(&self) -> &<OrchardDomain as Domain>::ExtractedCommitment {
+        &self.cmx
     }
 
     fn enc_ciphertext(&self) -> &[u8; COMPACT_NOTE_SIZE] {

Original file line number	Diff line number	Diff line change
`@@ -265,8 +265,8 @@ impl<T> ShieldedOutput<OrchardDomain, ENC_CIPHERTEXT_SIZE> for Action<T> {`
`265`	`265`	`EphemeralKeyBytes(self.encrypted_note().epk_bytes)`
`266`	`266`	`}`
`267`	`267`
`268`		`- fn cmstar_bytes(&self) -> [u8; 32] {`
`269`		`- self.cmx().to_bytes()`
	`268`	`+ fn cmstar(&self) -> &<OrchardDomain as Domain>::ExtractedCommitment {`
	`269`	`+ self.cmx()`
`270`	`270`	`}`
`271`	`271`
`272`	`272`	`fn enc_ciphertext(&self) -> &[u8; ENC_CIPHERTEXT_SIZE] {`
`@@ -279,8 +279,8 @@ impl ShieldedOutput<OrchardDomain, ENC_CIPHERTEXT_SIZE> for crate::pczt::Action`
`279`	`279`	`EphemeralKeyBytes(self.output().encrypted_note().epk_bytes)`
`280`	`280`	`}`
`281`	`281`
`282`		`- fn cmstar_bytes(&self) -> [u8; 32] {`
`283`		`- self.output().cmx().to_bytes()`
	`282`	`+ fn cmstar(&self) -> &<OrchardDomain as Domain>::ExtractedCommitment {`
	`283`	`+ self.output().cmx()`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`fn enc_ciphertext(&self) -> &[u8; ENC_CIPHERTEXT_SIZE] {`
`@@ -321,8 +321,8 @@ impl ShieldedOutput<OrchardDomain, COMPACT_NOTE_SIZE> for CompactAction {`
`321`	`321`	`EphemeralKeyBytes(self.ephemeral_key.0)`
`322`	`322`	`}`
`323`	`323`
`324`		`- fn cmstar_bytes(&self) -> [u8; 32] {`
`325`		`- self.cmx.to_bytes()`
	`324`	`+ fn cmstar(&self) -> &<OrchardDomain as Domain>::ExtractedCommitment {`
	`325`	`+ &self.cmx`
`326`	`326`	`}`
`327`	`327`
`328`	`328`	`fn enc_ciphertext(&self) -> &[u8; COMPACT_NOTE_SIZE] {`