-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
C-bugCategory: This is a bugCategory: This is a bugI-error-handlingProblems and improvements related to error handlingProblems and improvements related to error handling
Description
zallet start
uses the same approach for task shutdown as zebrad start
. However, I didn't notice that zebrad
doesn't use the TokioComponent
from abscissa_tokio
; it uses its own TokioComponent
with the same name but that has interrupt-catching logic to let aborted futures finish (rather than cutting them off). abscissa_tokio
's lack of this logic is leading to Zallet calling std::process::exit
too quickly, which I think is causing some state corruption bugs.
We should either emulate what zebrad
does (and consider upstreaming it into abscissa_tokio
), or build our own shutdown listener logic (like I did in zcash-devtool
).
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bugCategory: This is a bugI-error-handlingProblems and improvements related to error handlingProblems and improvements related to error handling