Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheme theme not updated #12882

Closed
1 task done
Angelk90 opened this issue Jun 11, 2024 · 2 comments
Closed
1 task done

Scheme theme not updated #12882

Angelk90 opened this issue Jun 11, 2024 · 2 comments
Labels
bug [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc

Comments

@Angelk90
Copy link
Contributor

Angelk90 commented Jun 11, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I took a look at the example scheme here: https://zed.dev/schema/themes/v0.1.0.json
I compared it to the themes found on extensions.

I noticed the following problems:

  1. In the example scheme the following is used: scrollbar_thumb.background but in many themes scrollbar.thumb.background is used instead which of the two is correct?

  2. Many are missing the description, for example in players what does it do?

  3. In many themes you will find accents, what is it for?

  4. There is no information about syntax, what properties it may have and more.

@Angelk90 Angelk90 added admin read bug [core label] labels Jun 11, 2024
@JosephTLyons JosephTLyons added extension infrastructure Feedback for extensions APIs, creation, management, etc and removed triage labels Jun 12, 2024
@notpeter
Copy link
Member

cc: @maxdeviant

@notpeter
Copy link
Member

I've published an updated theme schema on the website as part of:

You can find the current version here:

@notpeter notpeter closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc
Projects
None yet
Development

No branches or pull requests

3 participants