Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks Oh My Zsh display in integrated terminal #14154

Open
1 task done
Abdur-rahmaanJ opened this issue Jul 11, 2024 · 8 comments
Open
1 task done

Breaks Oh My Zsh display in integrated terminal #14154

Abdur-rahmaanJ opened this issue Jul 11, 2024 · 8 comments
Labels
bug [core label] linux terminal Feedback for terminal integration, shell commands, etc

Comments

@Abdur-rahmaanJ
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  • Use Linux Mint
  • Insytall Oh My Zsh
  • Open integrated terminal and see Oh My Zsh's broken display

Environment

Does not work

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot from 2024-07-10 23-48-51

If applicable, attach your Zed.log file to this issue.

Zed.log

@notpeter notpeter added terminal Feedback for terminal integration, shell commands, etc linux and removed triage labels Jul 11, 2024
@srihariash999
Copy link

I got this issue, with oh my zsh as well. But when i close and reopen the terminal tab, the UI got fixed.
Still, it happens occasionally, especially when launched for the first time.

@Abdur-rahmaanJ can you see if it gets corrected for you as well if you close and open the integrated terminal?

@logesh-kumar
Copy link

logesh-kumar commented Dec 20, 2024

The issue is still there I can reproduce it. Closing and reopening does not help.
Screenshot 2024-12-20 at 2 38 03 PM

@andreafspeziale
Copy link

Same here. On Macbook. It is quite annoying 😞

Screenshot 2024-12-29 alle 01 30 35

@andreafspeziale
Copy link

andreafspeziale commented Dec 29, 2024

Another example of awkward render (left Zed, right Ghostty)
Screenshot 2024-12-30 alle 00 19 24

edit

VSC running just fine
Screenshot 2024-12-30 alle 01 12 23

@cartercanedy
Copy link

alacritty (which is what zed embeds for the integrated terminal) is notorious for bad unicode style handling by default. In the desktop app, you can configure this to look a bit better, but as far as I know there's no zed conf options exposed to improve the experience of the integrated terminal...

@andreafspeziale
Copy link

I don't know the complexity and implications about what I'm going to say, but would it make sense to attach it to whatever a user is using instead of providing an arbitrary one? Or even as some kind of provider which can be set in the settings.

Would it make senso to have it as a feature request? Just wondering...

@cartercanedy
Copy link

cartercanedy commented Jan 11, 2025

I soldspoke a little too soon, alacritty handles the pty logic, but zed has their own rendering frontend for actually presenting the graphical terminal in the editor. It looks like they're planning to migrate the embedded terminal to libghostty, but they're deep into the git integrations and AI assistant tooling, do I don't anticipate this to get resolved anytime soon

@abhinavkbij
Copy link

Adding a solution that worked for me where font rendering was the issue, I had to add the font family used by Kitty(my default terminal emulator) config and the rendering improved in Zed terminal. Attaching screenshots here for reference

Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] linux terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

No branches or pull requests

7 participants