Zed logs error for missing ~/.config/github-copilot (linux)

[anthonyryan1]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

1. Update settings.json to disable GitHub Copilot, because I don't want the contents of my text editor sent to a 3rd party in the background.

  "features": {
    "inline_completion_provider": "none"
  }

2. Startup Zed
3. Check Zed.log

grep -rni copilot ~/.local/share/zed/logs/Zed.log

2024-09-14T16:10:05.81434634-04:00 [ERROR] No such file or directory (os error 2) about ["/home/ar/.config/github-copilot"]

If copilot is properly disabled, why is it searching searching for it's config/API keys?

Environment

Zed: v0.152.3 (Zed)
OS: Linux Wayland gentoo 2.15
Memory: 31.3 GiB
Architecture: x86_64
GPU: AMD Radeon RX 570 Series (RADV POLARIS10) || radv || Mesa 24.1.6

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

[sa1]

Apart from the inline provider, there's also the AI chat. I suspect Zed looks at which providers you're signed into for the chat.

[anthonyryan1]

Not currently preventing startup for me. No current lead on why that part differs for you.

[notpeter]

Yeah, looking at the code the GitHub Copilot Chat via the Assistant panel uses that file:

zed/crates/copilot/src/copilot_chat.rs

Lines 175 to 187 in 0f4ebdf

	fn copilot_chat_config_path() -> &'static PathBuf {
	static COPILOT_CHAT_CONFIG_DIR: OnceLock<PathBuf> = OnceLock::new();
	COPILOT_CHAT_CONFIG_DIR.get_or_init(|| {
	if cfg!(target_os = "windows") {
	home_dir().join("AppData").join("Local")
	} else {
	home_dir().join(".config")
	}
	.join("github-copilot")
	.join("hosts.json")
	})
	}

I was able to reproduce by removing my .config/github-copilot/ directory and restarting Zed. I tried on Linux/MacOS, but the error only showed on linux.

Thanks for reporting.

[notpeter]

I did some digging and I believe this is happening because we add a watch for ~/.config/github-copilot/hosts.json.

zed/crates/copilot/src/copilot_chat.rs

Lines 195 to 199 in f5124c2

	let mut config_file_rx = watch_config_file(
	cx.background_executor(),
	fs,
	copilot_chat_config_path().clone(),
	);

If the github-copilot directory does not exist, then attempting to add a watch for a file in a directory that does not exist will generate an error. I believe this is also impacting Windows users as well. The MacOS implementation of watch appears unaffected.

zed/crates/fs/src/fs.rs

Lines 524 to 525 in f5124c2

	#[cfg(target_os = "macos")]
	async fn watch(

[notpeter]

I believe this was fixed by:

• Fix: Copilot Chat is logged out  #21360

More info here

If you are still seeing this in your logs with a current release, please comment with more details and I'm happy to reopen.