can't tab through input fields in project search after latest update

[hedefalk]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

I have:

  {
    "context": "Editor && !showing_completions",
    "bindings": {
      "tab": "editor::Indent"
    }
  }

for indenting in editor context only.

Since last update I cannot tab through the fields of project search, but just insert tabs instead:

I'm positive this worked before but it seems the "Editor && !showing_completions" context is now active even if cursor is in project search. If I remove my keysettings it works as normal.

Environment

Zed: v0.154.3 (Zed)
OS: macOS 14.6.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

[hedefalk]

I've tried all kinds of resetting by looking at defaultkeymap but nothing seems to work but removing my existing keymap for tab:

{
    "context": "ProjectSearchBar",
    "bindings": {
      "tab": "menu::SelectNext"
    }
  },

  {
    "context": "ProjectSearchBar > Editor",
    "bindings": {
      "tab": "menu::SelectNext"
    }
  },
  {
    "context": "ProjectSearchBar && in_replace > Editor",
    "bindings": {
      "tab": "menu::SelectNext"
    }
  },
  {
    "context": "ProjectSearchView",
    "bindings": {
      "tab": "menu::SelectNext"
    }
  }

Is there any good documentation on these contexts?

[CharlesChen0823]

this is interesting, i don't set any keybindings for this, tab always worked IIRC in windows.

[JosephTLyons]

I also don't have any keybindings and tab has always worked for me to cycle through input fields in project search. 🤔

[notpeter]

There is some context documentation here:

• https://zed.dev/docs/key-bindings#contexts

But it definitely needs some work:

• Document keymap context #14718

We've recently added debug: open key context view (accessible from the command palette) which definitely can help shed some light on this stuff:

The above is the "Find in files" and it's Editor && mode=single_line while in a normal editor it's Editor && mode=full. You should be able to adjust your keybindings appropriately, either by changing the context of your existing bind or by rebinding Editor::Tab in the BufferSearchBar context.

There's definitely some complexity here, but I think this is behaving as designed.

[hedefalk]

I still can't figure this out.

I have:

{
    "context": "Editor && !showing_completions",
    "bindings": {
      "tab": "editor::Indent"
    }
  },
  {
    "context": "ProjectSearchBar > Editor",
    "bindings": {
      "tab": "menu::SelectNext"
    }
  }

According to the rules defined at https://zed.dev/docs/key-bindings#precedence they are of the same level and therefore the latter one should take precendence. It doesn't:

The other suggestion with Editor && mode=single_line doesn't parse?