Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.162.1: Vim mode escape sequence prefixes no longer inserted in Insert mode #20732

Closed
1 task done
smsegal opened this issue Nov 15, 2024 · 4 comments
Closed
1 task done
Labels
duplicate Additional reports of an existing issue vim

Comments

@smsegal
Copy link

smsegal commented Nov 15, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I have the following snippet in my keymap.json that enables me to use a keychord to escape from Insert mode back to Normal.

  {
    "context": "vim_mode == insert",
    "bindings": {
      "f d": "vim::NormalBefore",
    }
  }

The expected behaviour when pressing "f d" is to switch from Insert -> Normal when the second key in the sequence is observed (up to a timeout period). This worked as intended on versions < 0.162.1.

On Zed Preview (0.162.1), the first key in the sequence (f in my case) is no longer inserted into the buffer. If I press the full sequence, I do still go from insert -> normal, but I can no longer type an f at all.

There are a couple of other confirmed reports of the same issue on the discord #vim-mode, although I'm not sure how to permalink those.

I've downgraded back to Zed Stable (0.161.2) and the keys are working as expected.

Environment

Zed: v0.162.1 (Zed Preview)
OS: macOS 15.1.0
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log Had to truncate the log, had work-related project names etc in there. These are the most recent two lines, and nothing else *seems* related.
2024-11-15T12:06:09.215796-05:00 [WARN] unhandled capability registration: Registration { id: "8a7d8c71-eb17-4684-994f-11cbbc0d664c", method: "workspace/didChangeConfiguration", register_options: Some(Object {"section": String("bashIde")}) }
2024-11-15T12:06:09.961735-05:00 [INFO] skipping numeric progress token 16807
@smsegal smsegal added admin read bug [core label] labels Nov 15, 2024
@smsegal
Copy link
Author

smsegal commented Nov 20, 2024

Looks like the new stable release also suffers from this bug. I haven't updated to test, since it's unclear if I can downgrade to an older version (and tbh, I don't feel like going through the effort during the workday).

@akbxr
Copy link

akbxr commented Nov 20, 2024

Looks like the new stable release also suffers from this bug. I haven't updated to test, since it's unclear if I can downgrade to an older version (and tbh, I don't feel like going through the effort during the workday).

I've updated it, it's fixed in the latest preview and stable version.

@smsegal
Copy link
Author

smsegal commented Nov 21, 2024

Awesome, can confirm it's fixed for me as well. Will close.

@smsegal smsegal closed this as completed Nov 21, 2024
@notpeter notpeter added duplicate Additional reports of an existing issue vim and removed bug [core label] triage labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Additional reports of an existing issue vim
Projects
None yet
Development

No branches or pull requests

4 participants