vim: Add sneak motion (continued) #21067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement support for the vim sneak motion from the vim-sneak plugin. The motion jumps forward or backward to any location specified by two characters. The Sneak & SneakBackward operators are bound to 'z' and 'Z' by default to avoid overwriting the 's' and 'S' default keybindings, similar to the way the original plugin uses 'z' with operators to avoid conflicts. Reference: https://github.com/justinmk/vim-sneak
notpeter
added
the
cla-signed
# Conflicts: # crates/vim/src/vim.rs
|
@ConradIrwin I saw you approved my other vim PR, just pinging you to make sure this hasn't accidentally fallen by the wayside. Thank you for the help! |
|
It's on my list, this one is a bit larger and I didn't have time last week. |
|
@vultix Thanks for this! The sneak code looks good to me. I'd like to not add a setting for this, but instead document how to set up the bindings (as we do for subword motions, and vim surround). Happy to pair with you on making that change if you want: https://calendly.com/conradirwin/pairing |
|
Closing for now, but still interested in getting this merged! |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
A (re)continuation of #21067. This takes the original implementation in #15572 and adds the test in #21067. Then, as requested in #21067 (comment), it documents how to map a keybinding instead of having a setting. Closes #13858 Release Notes: - Added support for the popular [vim_sneak](https://github.com/justinmk/vim-sneak) plugin. This is disabled by default and can be enabled by binding a key to the `Sneak` and `SneakBackward` operators. Reference: https://github.com/justinmk/vim-sneak --------- Co-authored-by: Kajetan Puchalski <[email protected]> Co-authored-by: Aidan Grant <[email protected]> Co-authored-by: Conrad Irwin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the abandoned #15572 pull request.
As requested in that PR, I added tests and a new
enable_vim_sneaksetting so we don't override thesandSshortcuts by default.Closes #13858
Release Notes:
"enable_vim_sneak": truein your vim settings.Reference:
https://github.com/justinmk/vim-sneak