Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open folds containing selections when jumping from multibuffer #21433

Merged

Conversation

cole-miller
Copy link
Contributor

When searching within a single buffer, activating a search result causes any fold containing the result to be unfolded. However, this didn't happen when jumping to a search result from a project-wide search multibuffer. This PR fixes that.

Release Notes:

  • Fixed folds not opening when jumping from search results multibuffer

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2024
@cole-miller cole-miller marked this pull request as draft December 3, 2024 02:38
@cole-miller
Copy link
Contributor Author

(This doesn't work yet, WIP)

@cole-miller cole-miller force-pushed the multibuffer-jump-unfold branch from d48ec5c to c61a6a4 Compare December 3, 2024 21:07
@cole-miller cole-miller marked this pull request as ready for review December 3, 2024 21:08
@cole-miller
Copy link
Contributor Author

Fixed and now with a test!

@cole-miller cole-miller merged commit dc32ab2 into zed-industries:main Dec 3, 2024
12 checks passed
cole-miller added a commit to cole-miller/zed that referenced this pull request Dec 5, 2024
cole-miller added a commit that referenced this pull request Dec 5, 2024
#21433)" (#21566)

This reverts commit dc32ab2.

This has been causing panics, backing it out while figuring out what's
up.

Release Notes:

- N/A
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 5, 2024
#21433)" (#21566)

This reverts commit dc32ab2.

This has been causing panics, backing it out while figuring out what's
up.

Release Notes:

- N/A
cole-miller added a commit that referenced this pull request Dec 5, 2024
#21433)" (cherry-pick #21566) (#21569)

Cherry-picked Revert "Open folds containing selections when jumping from
multibuffer (#21433)" (#21566)

This reverts commit dc32ab2.

This has been causing panics, backing it out while figuring out what's
up.

Release Notes:

- N/A

Co-authored-by: Cole Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant