-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim: Fix key navigation on folded buffer headers #25944
Conversation
Co-authored-by: João Marcos <[email protected]>
Co-authored-by: João Marcos <[email protected]>
Oh, possible this mitigates one of the related issues I mention in #25951 |
Great, thanks for that issue (and sorry for not fixing the scroll thing when you brought it up on discord weeks ago :D). Looks like Also will look into the scroll position stuff; I think we should probably use the location of your cursor as well as / instead of the scroll anchor for figuring that out. |
Eh, I've seen the git channel notes... there's a flood of things y'all are working through and this is a minor thing. I'm very impressed with the git panel already; way more than expected in phase one. Amazing work!
Yeah, expand/collapse is something I know is there, but has always been finicky when trying to use it in vim so I've mostly ignored it. Multibuffers have always been cool, but take on extra shine to me now with diffs, so will probably try to leverage them more. |
/cherry-pick v0.177.x |
Closes #24243 Release Notes: - vim: Fix j/k on folded multibuffer headers --------- Co-authored-by: João Marcos <[email protected]>
…#25972) Cherry-picked vim: Fix key navigation on folded buffer headers (#25944) Closes #24243 Release Notes: - vim: Fix j/k on folded multibuffer headers --------- Co-authored-by: João Marcos <[email protected]> Co-authored-by: Conrad Irwin <[email protected]> Co-authored-by: João Marcos <[email protected]>
#25944 but now with Vim mode off. Release Notes: - N/A
Closes #24243
Release Notes: