Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Fix key navigation on folded buffer headers #25944

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

ConradIrwin
Copy link
Member

Closes #24243

Release Notes:

  • vim: Fix j/k on folded multibuffer headers

ConradIrwin and others added 2 commits March 3, 2025 10:41
Co-authored-by: João Marcos <[email protected]>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 3, 2025
@baldwindavid
Copy link
Contributor

baldwindavid commented Mar 3, 2025

Oh, possible this mitigates one of the related issues I mention in #25951

@ConradIrwin
Copy link
Member Author

Great, thanks for that issue (and sorry for not fixing the scroll thing when you brought it up on discord weeks ago :D).

Looks like za and friends also don't work inside deleted content, I'll fix that.

Also will look into the scroll position stuff; I think we should probably use the location of your cursor as well as / instead of the scroll anchor for figuring that out.

@ConradIrwin ConradIrwin merged commit 0bd40da into main Mar 3, 2025
12 checks passed
@ConradIrwin ConradIrwin deleted the vim-multibuffer-headers branch March 3, 2025 21:44
@baldwindavid
Copy link
Contributor

Great, thanks for that issue (and sorry for not fixing the scroll thing when you brought it up on discord weeks ago :D).

Eh, I've seen the git channel notes... there's a flood of things y'all are working through and this is a minor thing. I'm very impressed with the git panel already; way more than expected in phase one. Amazing work!

Looks like za and friends also don't work inside deleted content, I'll fix that.

Yeah, expand/collapse is something I know is there, but has always been finicky when trying to use it in vim so I've mostly ignored it. Multibuffers have always been cool, but take on extra shine to me now with diffs, so will probably try to leverage them more.

@ConradIrwin
Copy link
Member Author

/cherry-pick v0.177.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 4, 2025
Closes #24243

Release Notes:

- vim: Fix j/k on folded multibuffer headers

---------

Co-authored-by: João Marcos <[email protected]>
ConradIrwin added a commit that referenced this pull request Mar 4, 2025
…#25972)

Cherry-picked vim: Fix key navigation on folded buffer headers (#25944)

Closes #24243

Release Notes:

- vim: Fix j/k on folded multibuffer headers

---------

Co-authored-by: João Marcos <[email protected]>

Co-authored-by: Conrad Irwin <[email protected]>
Co-authored-by: João Marcos <[email protected]>
marcospb19 added a commit that referenced this pull request Mar 7, 2025
#25944 but now with Vim mode off.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folding entries in project search traps cursor in vim mode
2 participants