Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key binding "ctrl+`" creates an invalid character #4624

Closed
1 task done
Spoutnik97 opened this issue Jul 16, 2023 · 5 comments
Closed
1 task done

key binding "ctrl+`" creates an invalid character #4624

Spoutnik97 opened this issue Jul 16, 2023 · 5 comments
Labels
bug [core label] workspace Feedback for workspace management, layout, interactions, etc

Comments

@Spoutnik97
Copy link

Spoutnik97 commented Jul 16, 2023

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I would like to open the terminal panel with the keybinding "ctrl+`" 'like on VSCode, but instead of opening a new panel, Zed write an "invalid character" in the current file. This character is invisible on Zed, but visible on VsCode
image

I don't understand how to debug this

Environment

Zed: v0.94.4 (stable)
OS: macOS 13.4.0
Memory: 16 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@Spoutnik97 Spoutnik97 added admin read bug [core label] labels Jul 16, 2023
@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Jul 17, 2023

Hmmm, I actually can't reproduce this @Spoutnik97. Would you feel comfortable pasting in your settings.json and keymap.json contents?

@JosephTLyons JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc and removed triage labels Jul 17, 2023
@JosephTLyons
Copy link
Collaborator

Actually, can you also clarify the keybinding you're using?

@Spoutnik97
Copy link
Author

My settings.json :
// Zed settings // // For information on how to configure Zed, see the Zed // documentation: https://zed.dev/docs/configuring-zed // // To see all of Zed's default settings without changing your // custom settings, run the open default settingscommand // from the command palette or fromZedapplication menu. { "base_keymap": "VSCode", "theme": "One Dark", "buffer_font_size": 15, "formatter": { "external": { "command": "eslint", "arguments": [ "{buffer_path}" ] } }, "language_overrides": { "TypeScript": { "format_on_save": { "external": { "command": "eslint", "arguments": [ "{buffer_path}" ] } }, "formatter": "language_server" } } }

keymap.json :

[
  {
    "bindings": {
      "ctrl-ù": "workspace::ToggleBottomDock",
      "ctrl-t": "assistant::Assist"�
    }
  },
  {
    "context": "Editor",
    "bindings": {
      "alt-up": "editor::MoveLineUp",
      "alt-down": "editor::MoveLineDown",
      "alt-shift-down": "editor::DuplicateLine",
    }
  }
]

Just to clarify, I am using an AZERTY (french keyboard on macos). I am using the "ctrl+`" keybinding

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@juliangarnier
Copy link

juliangarnier commented Sep 19, 2024

I have a similar problem when typing "ctrl-"` on an AZERTY french keyboard on macos, I can't see the character, but some invisible characters are being added to the document (you can see the characters count go up)

default.mov

Temporary solution

The solution was to actually type "ctrl-<" as listed in the "View" menu, even if the default key bindings is configured with :

"ctrl-`": "terminal_panel::ToggleFocus",

Screenshot 2024-09-19 at 16 31 22

Screenshot 2024-09-19 at 16 24 52

Pretty sure this is a duplicate of #5195 and #5196.

Could this be resolved by #17031?

@notpeter
Copy link
Member

notpeter commented Dec 3, 2024

The original issue here (ctrl-` creates an invalid character) should be fixed in recent Zed versions. If I am mistaken, please comment below with reproduction instructions (this does not reproduce for me in AZERTY, Spanish or US English). For more see:

If you have a similar issue please search the existing issues to see if you issue has already been reported:

Thanks for reporting!

@notpeter notpeter closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

4 participants