Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: can not link library in plugin.cmake #40

Open
AmazingPP opened this issue Sep 20, 2024 · 1 comment
Open

plugin: can not link library in plugin.cmake #40

AmazingPP opened this issue Sep 20, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@AmazingPP
Copy link
Contributor

The top-level CMakeLists.txt tell me do not edit it and put required additional cmake functionality into plugin.cmake, but I can't use zeek_plugin_link_library in plugin.cmake at all.

@zeek zeek deleted a comment from Lancoo2k Sep 20, 2024
@awelzel awelzel added the help wanted Extra attention is needed label Jan 8, 2025
@awelzel
Copy link
Contributor

awelzel commented Jan 8, 2025

Sorry for the delay here. Seems the comment is/was optimistic.

What maybe could be done is to introduce an "API" where plugin.cmake can modify a set of variables for "DEPENDENCIES" and "INCLUDE_DIRS" etc which are then picked up. I'm unsure that's a good pattern, however. Seems cleaner to treat the top-level CMakeLists.txt as a skeleton for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants