Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required Python version to 3.10 #101

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

bbannier
Copy link
Member

@bbannier bbannier commented Jan 21, 2025

With python-3.9 only receiving security updates some projects have stopped publishing wheels for new releases, e.g., tree-sitter requires python>=3.10 as of 0.24.0 so we cannot build wheels with that version anymore, see #100.

This PR bumps the minimum required Python version to 3.10. This means that we are incompatible with the Python requirements of e.g., https://github.com/zeek/zeek itself which currently requires python>=3.9. Since zeekscript is not required to operate Zeek this seems acceptable to me, especially given that python-3.9 will hit EOL 2025-10 so the rest of the Zeek ecosystem might bump its minimum requirement too in the nearer future (i.e., somewhere in the 7.2-8.x timeframe).

@bbannier bbannier self-assigned this Jan 21, 2025
@bbannier bbannier marked this pull request as ready for review January 21, 2025 06:13
@bbannier
Copy link
Member Author

@ckreibich @timwoj could you chime in on this? Like I wrote, this seems fine for an optional package.

Copy link
Member

@timwoj timwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I agree that it's an optional package that doesn't ship with Zeek, so it doesn't necessarily need to follow Zeek's version requirements.

@bbannier bbannier merged commit 7ac7b9c into main Jan 22, 2025
7 checks passed
@bbannier bbannier deleted the topic/bbannier/py310 branch January 22, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants