Fix formatting of nodes with no non-error children #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When formatting a `Node`'s child we allowed omitting passing in of the child to format. In that case the user would pass a `None` child and we would attempt to default to formatting the next non-error child. The helper we used to get that child could still return `None` (in case there were only error children remaining, or on incorrect use of the function when the node had no children), but we never handled that case; instead we would have surfaced an `AttributeError` like ``` AttributeError: 'NoneType' object has no attribute 'prev_error_siblings' ``` With this path we explicitly skip any child formatting if we found no child to be formatted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formatting a
Node's child we allowed omitting passing in of the child to format. In that case the user would pass aNonechild and we would attempt to default to formatting the next non-error child. The helper we used to get that child could still returnNone(in case there were only error children remaining, or on incorrect use of the function when the node had no children), but we never handled that case; instead we would have surfaced anAttributeErrorlikeWith this path we explicitly skip any child formatting if we found no child to be formatted.