Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode location icons #64

Open
leoetlino opened this issue Jun 24, 2023 · 2 comments
Open

Do not hardcode location icons #64

leoetlino opened this issue Jun 24, 2023 · 2 comments
Labels
bug Something isn't working cleanup

Comments

@leoetlino
Copy link
Member

Location icons shouldn't be hardcoded in make_static_list.py. Instead, we should do what the game actually does and cross reference locations against the LocationTable to determine the location icon and type

And come to think of it, maybe we should migrate away from the BotW-style static location data entirely

@leoetlino leoetlino added bug Something isn't working cleanup labels Jun 24, 2023
@savage13
Copy link
Contributor

is that ShieldSurfing_SeniorGoal supposed to show up?
shows up as a label on the map

@leoetlino
Copy link
Member Author

According to the LocationTable, it is supposed to show up with a custom "minigame goal" icon:

- {Category: SpotSmallArtifact, DependenceLocationHash: !u 0x7ea12150, OverrideIconFlagHash: !u 0x2bc71833,
   OverrideIconType: MiniGameGoal, __RowId: Work/Location/ShieldSurfing_SeniorGoal.game__location__Location.gyml}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup
Projects
None yet
Development

No branches or pull requests

2 participants