Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split view can't be resized vertically when bookmarks sidebar is open #2761

Open
4 tasks done
pettycrimes420 opened this issue Nov 9, 2024 · 9 comments · May be fixed by #4088
Open
4 tasks done

Split view can't be resized vertically when bookmarks sidebar is open #2761

pettycrimes420 opened this issue Nov 9, 2024 · 9 comments · May be fixed by #4088
Labels

Comments

@pettycrimes420
Copy link

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

As the title says. Vertical resizing of split tabs doesn't seem to work when firefox's native sidebar is open
Screencast From 2024-11-09 13-31-42.webm

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.17, 1.0.1-t.18

What platform are you seeing the problem on?

Linux

Relevant log output

No response

Copy link

dosubot bot commented Nov 9, 2024

Hello @pettycrimes420! I'm here to help you with any bugs, questions, or contributions you may have. Let's tackle this issue together!

I found a similar issue that might be related to your problem. The issue titled "Sidebar suddenly not working as it should" was closed, and the suggested solution was to create a new profile and copy over your data, as the new profile did not have the issue [1].

Additionally, the codebase includes logic that adjusts the layout or dimensions of the split view when the sidebar is toggled. The ZenViewSplitter class manages the split view layout, and methods like addTabToSplit and calculateLayoutTree handle the arrangement and resizing of tabs within the split view [2]. This might be relevant to the issue you're experiencing with vertical resizing when the sidebar is open.

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the Bug label Nov 9, 2024
@tomsik-radek
Copy link

I'm confirming this issue, 1.0.1-a.17 on Windows 23H2. It works with Sidebar + two tabs in split view. Option to resize the two split tabs is gone when I also open the Library (History menu etc)

@LeMoonStar
Copy link
Member

Hey! I can reproduce this issue - It is however important to note this is only the case with the Bookmarks Sidebar (The title sounds as if this is about Zen's sidebar/sidepanel/webpanel)

@LeMoonStar LeMoonStar moved this from Triage to ToDo in Zen Browser - public roadmap Nov 9, 2024
@pettycrimes420 pettycrimes420 changed the title Split view can't be resized vertically when sidebar is open Split view can't be resized vertically when bookmarks sidebar is open Nov 9, 2024
Copy link

dosubot bot commented Dec 10, 2024

Hi, @pettycrimes420. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Vertical resizing of split tabs in Firefox is not possible when the native bookmarks sidebar is open on Linux.
  • The issue is not reproducible on Mozilla Firefox itself.
  • Affects versions 1.0.1-a.17 and 1.0.1-t.18.
  • Suggested solution: Create a new profile.
  • Confirmed by users tomsik-radek and LeMoonStar, with clarification that it involves the Bookmarks Sidebar.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no response, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 10, 2024
@pettycrimes420
Copy link
Author

Confirmed still relevant

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 15, 2024
@vintydong vintydong linked a pull request Dec 31, 2024 that will close this issue
Copy link

dosubot bot commented Jan 22, 2025

Hi, @pettycrimes420. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary

  • Vertical resizing of split tabs in Firefox is not possible when the bookmarks sidebar is open on Linux.
  • Affects versions 1.0.1-a.17 and 1.0.1-t.18; not reproducible on Mozilla Firefox itself.
  • Confirmed by user tomsik-radek on Windows; involves the Bookmarks Sidebar as clarified by LeMoonStar.
  • I suggested creating a new profile; you confirmed the issue is still relevant.

Next Steps

  • Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 22, 2025
@pettycrimes420
Copy link
Author

* Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here.

Still is but there's been some work on it

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 22, 2025
@menganatha
Copy link

Related: #4680

@JSGRD22 JSGRD22 marked this as a duplicate of #4544 Feb 1, 2025
@JSGRD22
Copy link
Contributor

JSGRD22 commented Feb 1, 2025

Hey! I can reproduce this issue - It is however important to note this is only the case with the Bookmarks Sidebar (The title sounds as if this is about Zen's sidebar/sidepanel/webpanel)

I will add that, as of the current version, the issue applies to zen's web panels too, as stated in the duplicate issue above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Development

Successfully merging a pull request may close this issue.

5 participants