Skip to content

Commit 0467b95

Browse files
committed
Fix unreachable return in analytics tracking by handling exceptions
1 parent 992fff1 commit 0467b95

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/mlstacks/analytics/client.py

+8-3
Original file line numberDiff line numberDiff line change
@@ -161,16 +161,21 @@ def track_event(
161161
metadata: Dict of metadata to track.
162162
163163
Returns:
164-
True if event is sent successfully, False is not.
164+
True if event is sent successfully, False otherwise.
165165
"""
166166
if metadata is None:
167167
metadata = {}
168168

169169
metadata.setdefault("event_success", True)
170170

171171
with MLStacksAnalyticsContext() as analytics_context:
172-
return bool(analytics_context.track(event=event, properties=metadata))
173-
return False
172+
try:
173+
return bool(
174+
analytics_context.track(event=event, properties=metadata)
175+
)
176+
except Exception:
177+
logger.exception("Error occurred during analytics tracking")
178+
return False
174179

175180

176181
class EventHandler:

0 commit comments

Comments
 (0)