Skip to content

Commit 95a67f6

Browse files
authored
ci: forbid print statements in frontend and backend (#39)
1 parent 9314a06 commit 95a67f6

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

backend/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ backend = "zeno_backend.server:serve"
4545
include = ["zeno_backend"]
4646

4747
[tool.ruff]
48-
select = ["E", "F", "I", "PD", "N", "D"]
48+
select = ["E", "F", "I", "PD", "N", "D", "T20"]
4949

5050
[tool.ruff.pydocstyle]
5151
convention = "google"

backend/zeno_backend/processing/util.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,9 @@ def generate_diff_cols(
2929
diff_col_1.column_type != diff_col_2.column_type
3030
or diff_col_1.data_type != diff_col_2.data_type
3131
):
32-
print("error: different column types!")
3332
return df
3433

3534
if diff_col_1.model is None or diff_col_2.model is None:
36-
print("error: no model specified!")
3735
return df
3836

3937
col1_id = column_id_from_name_and_model(

backend/zeno_backend/server.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ def add_organization(user: User, organization: Organization):
300300
@api_app.post("/add_project_user/{project}", tags=["zeno"])
301301
def add_project_user(project: str, user: User):
302302
insert.project_user(project, user)
303-
return user.name
303+
return user.email
304304

305305
@api_app.post("/add_project_org/{project}", tags=["zeno"])
306306
def add_project_org(project: str, organization: Organization):
@@ -346,7 +346,7 @@ def update_project(project: ProjectConfig):
346346
@api_app.post("/project_user/update/{project}", tags=["zeno"])
347347
def update_project_user(project: str, user: User):
348348
update.project_user(project, user)
349-
return user.name
349+
return user.email
350350

351351
@api_app.post("/project_org/update/{project}", tags=["zeno"])
352352
def update_project_org(project: str, organization: Organization):
@@ -382,7 +382,7 @@ def delete_organization(organization: Organization):
382382
@api_app.delete("/project_user/{project}", tags=["zeno"])
383383
def delete_project_user(project: str, user: User):
384384
delete.project_user(project, user)
385-
return user.name
385+
return user.email
386386

387387
@api_app.delete("/project_org/{project}", tags=["zeno"])
388388
def delete_project_org(project: str, organization: Organization):
@@ -395,9 +395,4 @@ def delete_project_org(project: str, organization: Organization):
395395
def serve():
396396
"""Serve the FastAPI application for the backend."""
397397
app = get_server()
398-
print(
399-
"\n\033[1mZeno server\033[0m running on http://{}:{}\n".format(
400-
"localhost", 8000
401-
)
402-
)
403398
uvicorn.run(app, host="localhost", port=8000, log_level="error")

frontend/.eslintrc.cjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,8 @@ module.exports = {
2626
parser: '@typescript-eslint/parser'
2727
}
2828
}
29-
]
29+
],
30+
rules: {
31+
'no-console': 'error'
32+
}
3033
};

0 commit comments

Comments
 (0)