Skip to content

Commit eb797fd

Browse files
committed
Installation: delete step to comment out WCharacter from ArduinoCore API
The issue has now been resolved, and we no longer need to comment out that library. Signed-off-by: Dhruva Gole <[email protected]>
1 parent 99c10fd commit eb797fd

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

README.md

-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ The `cores` folder can be found at `~/zephyrproject/modules/lib/Arduino-Zephyr-A
4040

4141
__NOTE:__ You can skip this step as well if you ran ``install.sh``.
4242

43-
* While compiling with the ArduinoCore-API `WCharacter.h` produces many errors. The include of that file needs to be deleted from `cores/arduino/api/ArduinoAPI.h` (it is unused in this port.) We are looking into resolving the issue.
44-
4543
**Maintainers**:
4644
- [DhruvaG2000](https://github.com/DhruvaG2000)
4745
- [soburi](https://github.com/soburi)

install.sh

-4
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ else
2222
printf '%s\n' "API Folder already exists, skipping clone...";
2323
fi
2424

25-
printf '%s\n' "Commenting out WCharacter.h because it fails to build properly";
26-
sed '/WCharacter.h/ s/./\/\/ &/' ~/.ArduinoCore-API/api/ArduinoAPI.h > ~/.ArduinoCore-API/api/tmpArduinoAPI.h ;
27-
mv ~/.ArduinoCore-API/api/tmpArduinoAPI.h ~/.ArduinoCore-API/api/ArduinoAPI.h ;
28-
2925
printf '%s\n' "Linking...";
3026
ln -sf ~/.ArduinoCore-API/api cores/arduino/. ;
3127

0 commit comments

Comments
 (0)