Bluetooth: Classic: OBEX enablement #83781
Open
+7,948
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Controller
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
carlescufi,
cvinayak,
erbr-ot,
hermabe,
jhedberg,
mtpr-ot,
rugeGerritsen,
sjanc,
Thalley,
theob-pro,
thoh-ot and
wopu-ot
|
Another massive PR? :) @lylezhu2012 I think the L2CAP and RFCOMM improvements could at least be split out into their own PRs. That way I think we can make faster progress with getting functionality merged incrementally. |
Actually, my PR only implements basic goep/obex operations, but goep and obex define too many concepts.
Well, I will remove all other layers changes from this PR. And make small PR for these changes. |
lylezhu2012
force-pushed
the
obex_enablement
branch
4 times, most recently
from
1dfaefe to
e4a2256
Compare
lylezhu2012
force-pushed
the
obex_enablement
branch
from
e4a2256 to
f70741b
Compare
|
test failure is unrelated and will be fixed with #83907 |
makeshi
reviewed
Jan 14, 2025
makeshi
reviewed
Jan 14, 2025
makeshi
reviewed
Jan 14, 2025
lylezhu2012
force-pushed
the
obex_enablement
branch
from
f70741b to
59ac793
Compare
lylezhu2012
force-pushed
the
obex_enablement
branch
2 times, most recently
from
4c7feba to
2177c21
Compare
lylezhu2012
force-pushed
the
obex_enablement
branch
2 times, most recently
from
6ad4f54 to
8433ca6
Compare
lylezhu2012
force-pushed
the
obex_enablement
branch
4 times, most recently
from
11d4c7b to
a31f46a
Compare
Add a Kconfig BT_GOEP to control the GOEP feature. Implement the GOEP protocol and transport, both for GOEP 1.1 and GOEP 2.x. For GOEP transport, OBEX over RFCOMM, and OBEX over L2CAP are supported. For GOEP protocol, `put`, `get`, `abort`, `setpath`, and `action` are supported. And only one operation can be processed at the same time. The feature `Reliable Session` is unsupported. Signed-off-by: Lyle Zhu <[email protected]>
The MTU of the GOEP should be not less than 255. So, if the transport is RFCOMM, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 264. It includes, - 255 bytes for the minimum MTU of GOEP, - 4 bytes for L2CAP Header, - 5 bytes for RFCOMM header and FCS. And if the transport is L2CAP, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 259. It includes, - 255 bytes for the minimum MTU of GOEP, - 4 bytes for L2CAP Header. Add Kconfig `BT_GOEP_RFCOMM_MTU` to configure the maximum size for RFCOMM transport. The range of `BT_GOEP_RFCOMM_MTU` is `[264, BT_RFCOMM_L2CAP_MTU]`. And the GOEP MTU via RFCOMM transport should be in the range `[255, (BT_GOEP_RFCOMM_MTU-9)]`. Add Kconfig `BT_GOEP_L2CAP_MTU` to configure the maximum size for L2CAP transport. The range of `BT_GOEP_L2CAP_MTU` is `[259, BT_BUF_ACL_RX_SIZE]`. And the GOEP MTU via L2CAP transport should be in the range `[255, (BT_GOEP_L2CAP_MTU-4)]`. Signed-off-by: Lyle Zhu <[email protected]>
Add commands for GOEP to test transport features. Add commands for transport over RFCOMM, including `register-rfcomm`, `connect-rfcomm`, and `disconnect-rfcomm`. Add commands for transport over L2CAP, including `register-l2cap`, `connect-l2cap`, and `disconnect-l2cap`. Signed-off-by: Lyle Zhu <[email protected]>
Add commands for GOEP to test OBEX features. Add command `alloc-buf` and `release-buf` to allocate and release TX buffer. Add command set `add-header` to add the OBEX headers to allocated TX buffer. Add command set `client` to send OBEX client requests with allocated TX buffer. Add command set `server` to send OBEX responses with allocated TX buffer. Signed-off-by: Lyle Zhu <[email protected]>
There are types of string can be added by using OBEX adding header function bt_obex_add_header_*(). One is byte sequence. Another is null terminated Unicode text. Add a function bt_obex_string_is_valid() to check if the added string is valid. And add a function bt_obex_unicode_is_valid() dedicated to check Unicode string. Signed-off-by: Lyle Zhu <[email protected]>
Add a structure `struct bt_obex_tlv` to pass/save the one TLV info. Use a array of `struct bt_obex_tlv` as the set of all TLV-triplets. Update the following functions to support the feature, including `bt_obex_add_header_app_param`, `bt_obex_add_header_auth_challenge`, and `bt_obex_add_header_auth_rsp`. Add a function `bt_obex_tlv_parse` to parse the encoded TLV-triplets. Signed-off-by: Lyle Zhu <[email protected]>
Add a TLV array `tlvs` to keep the pending TLV data. Update `app_param`, `auth_challenge`, and `auth_rsp` to set the one TLV information each time. When the optional argument `last` set, write the all pending TLVs to the tx buffer. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
obex_enablement
branch
from
a31f46a to
718df54
Compare
According to the OBEX Version 1.5, the Name header could be a empty string. Update function `bt_obex_add_header_name` to support the case that the length of name could be 0. Update function `bt_obex_get_header_name` to support the case that the name header is found but the name length is 0. Signed-off-by: Lyle Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Kconfig BT_GOEP to control the GOEP feature.
Implement the GOEP protocol and transport, both for GOEP 1.1 and GOEP 2.x.
For GOEP transport, OBEX over RFCOMM, and OBEX over L2CAP are supported.
For GOEP protocol,
put,get,abort,setpath, andactionare supported. And only one operation can be processed at the same time. The featureReliable Sessionis unsupported.The MTU of the GOEP should be not less than 255. So, if the transport is RFCOMM, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 264.
It includes,
And if the transport is L2CAP, the CONFIG_BT_BUF_ACL_RX_SIZE should be not less than 259.
It includes,
Add Kconfig
BT_GOEP_RFCOMM_MTUto configure the maximum size for RFCOMM transport. The range ofBT_GOEP_RFCOMM_MTUis[264, BT_RFCOMM_L2CAP_MTU]. And the GOEP MTU via RFCOMM transport should be in the range[255, (BT_GOEP_RFCOMM_MTU-9)].Add Kconfig
BT_GOEP_L2CAP_MTUto configure the maximum size for L2CAP transport. The range ofBT_GOEP_L2CAP_MTUis[259, BT_BUF_ACL_RX_SIZE]. And the GOEP MTU via L2CAP transport should be in the range[255, (BT_GOEP_L2CAP_MTU-4)].Add commands for GOEP to test transport features.
Add commands for transport over RFCOMM, including
register-rfcomm,connect-rfcomm, anddisconnect-rfcomm.Add commands for transport over L2CAP, including
register-l2cap,connect-l2cap, anddisconnect-l2cap.Add commands for GOEP to test OBEX features.
Add command
alloc-bufandrelease-bufto allocate and release TX buffer.Add command set
add-headerto add the OBEX headers to allocated TX buffer.Add command set
clientto send OBEX client requests with allocated TX buffer.Add command set
serverto send OBEX responses with allocated TX buffer.There are types of string can be added by using OBEX adding header function bt_obex_add_header_*(). One is byte sequence. Another is null terminated Unicode text.
Add a function bt_obex_string_is_valid() to check if the added string is valid. And add a function bt_obex_unicode_is_valid() dedicated to check Unicode string.