drivers: i2c: xilinx_axi: Remove nested spinlock #84016
Conversation
zephyrbot
added
area: I2C
size: XS
|
Hello @neeliajay, and thank you very much for your first pull request to the Zephyr project! |
zephyrbot
requested review from
henrikbrixandersen,
ibirnbaum,
michalsimek and
teburd
drivers/i2c/i2c_xilinx_axi.c
Outdated
| k_spin_unlock(&data->lock, key); | ||
| i2c_xilinx_axi_clear_interrupt(config, data, ISR_TX_FIFO_EMPTY | ISR_BUS_NOT_BUSY); |
There was a problem hiding this comment.
This introduces a window where the lock is released and then acquired again inside i2c_xilinx_axi_clear_interrupt, I'm not sure if that could cause some issues? Might be better to extract the portion of i2c_xilinx_axi_clear_interrupt which runs with the lock already acquired into a separate function, and then call that here before releasing the lock.
There was a problem hiding this comment.
sure.. added separate function i2c_xilinx_axi_clear_interrupt_no_lock
Removed nested spinlock acquisition in i2c_xilinx_axi_write to prevent ztest failures due to invalid spinlock usage. Ensured spinlocks are not consecutively acquired without unlocking, preventing potential deadlocks. Signed-off-by: Ajay Neeli <[email protected]>
neeliajay
force-pushed
the
i2c-xilinx-axi-remove-nested-spinlock
branch
from
c84ffcb to
f713b84
Compare
Removed nested spinlock acquisition in i2c_xilinx_axi_write to prevent ztest failures due to invalid spinlock usage.
Ensured spinlocks are not consecutively acquired without unlocking, preventing potential deadlocks.