dts: bindings: dai: Change the property names in the DTS #86332
+68
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
zephyrbot
requested review from
dbaluta,
fabiobaltieri,
iuliana-prodan,
juimonen,
kartben,
kv2019i,
LaurentiuM1234 and
lgirdwood
dbaluta
reviewed
Feb 26, 2025
| @@ -1,7 +1,7 @@ | |||
| afe_dl1: afe_dl1 { | |||
There was a problem hiding this comment.
Please explain WHY this change is needed. Why do we need to use dai_id instead of dai-id.
There was a problem hiding this comment.
See it :) #83741
There was a problem hiding this comment.
I know this, but please mention it in the commit message. A commit message should tell more about WHY the change is needed and less WHAT does the change do.
The WHAT should be obvious from the code :).
Rename the following properties in bindings and DTS: -- dai_id =>dai-id -- afe_name => afe-name -- agent_disable => agent-disable -- ch_num => ch-num -- mono_invert => mono-invert -- quad_ch => quad-ch -- int_odd => int-odd Signed-off-by: James Roy <[email protected]>
Add the following property renaming entries to the migration: * dai_id * afe_name * agent_disable * ch_num * mono_invert * quad_ch * int_odd Signed-off-by: James Roy <[email protected]>
rruuaanng
force-pushed
the
dts-style-dai
branch
from
7e2f213 to
cdeca44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the following properties in bindings and DTS:
-- dai_id =>dai-id
-- afe_name => afe-name
-- agent_disable => agent-disable
-- ch_num => ch-num
-- mono_invert => mono-invert
-- quad_ch => quad-ch
-- int_odd => int-odd