dts: bindings: espi: Change the property names in the DTS #86333
+28
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
zephyrbot
added
platform: Microchip MEC
zephyrbot
requested review from
albertofloyd,
fabiobaltieri,
jvasanth1,
kartben and
VenkatKotakonda
doc/releases/migration-guide-4.1.rst
Outdated
Comment on lines
207
to
214
| * Renamed the devicetree property ``io_girq`` to ``io-girq``. | ||
| * Renamed the devicetree property ``vw_girqs`` to ``vw-girqs``. | ||
| * Renamed the devicetree property ``pc_girq`` to ``pc-girq``. | ||
| * Renamed the devicetree property ``poll_timeout`` to ``poll-timeout``. | ||
| * Renamed the devicetree property ``poll_interval`` to ``poll-interval``. | ||
| * Renamed the devicetree property ``consec_rd_timeout`` to ``consec-rd-timeout``. | ||
| * Renamed the devicetree property ``sus_chk_delay`` to ``sus-chk-delay``. | ||
| * Renamed the devicetree property ``sus_rsm_interval`` to ``sus-rsm-interval``. |
There was a problem hiding this comment.
heya, afraid these will have to go in 4.2, late in the RC to keep changing these, sorry
There was a problem hiding this comment.
Sure. I once considered including it in section 4.2, but when I saw the completely empty migration guide, well, you know what I mean.
There was a problem hiding this comment.
yeah not a fan of having the 4.2 file in 4.1 to be totally honest, I think it's confusing, but that's what we decided to do... shrug
Rename the following properties in bindings and DTS: -- io_girq =>io-girq -- vw_girqs => vw-girqs -- pc_girq => pc-girq -- poll_timeout => poll-timeout -- poll_interval => poll-interval -- consec_rd_timeout => consec-rd-timeout -- sus_chk_delay => sus-chk-delay -- sus_rsm_interval => sus-rsm-interval Signed-off-by: James Roy <[email protected]>
Add the following property renaming entries to the migration: * io_girq * vw_girqs * pc_girq * poll_timeout * poll_interval * consec_rd_timeout * sus_chk_delay * sus_rsm_interval Signed-off-by: James Roy <[email protected]>
rruuaanng
force-pushed
the
dts-style-espi
branch
from
12da66e to
24af262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the following properties in bindings and DTS:
-- io_girq =>io-girq
-- vw_girqs => vw-girqs
-- pc_girq => pc-girq
-- poll_timeout => poll-timeout
-- poll_interval => poll-interval
-- consec_rd_timeout => consec-rd-timeout
-- sus_chk_delay => sus-chk-delay
-- sus_rsm_interval => sus-rsm-interval