tests/subsys/fs/nvs: Fix flakiness due to not init'ed data #86357
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aescolar thanks for the PR. In nvs the |
This test has been seen failing at random (though not often). A valgrind check showed the nvs_ate structures were being CRC'ed with not-initialized data, and checked later (assuming the CRC would be different than a constant). This maybe have been the cause of the test failures, so let's initialize the whole structure to prevent the CRC value from depending on random memory/stack content. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
tests_subsys_fs_nvs_flaky2
branch
from
cca1337 to
1515929
Compare
de-nordic
approved these changes
Feb 26, 2025
Laczen
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been seen failing at random (though not often). A valgrind check showed the nvs_ate structures were being CRC'ed with not-initialized data, and checked later (assuming the CRC would be different than a constant).
This may have been the cause of the test failures, so let's initialize the whole structure to prevent the CRC value from depending on random memory/stack content.